From 477d4bbf5f01e5c001a887ed6842e56b5341e976 Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sun, 12 Feb 2023 18:08:37 +0100 Subject: ci: inline external environment scripts (#22237) Scripts that define the build itself shouldn't be external as they lead to hard to find bugs. --- .github/workflows/codeql.yml | 3 --- 1 file changed, 3 deletions(-) (limited to '.github/workflows/codeql.yml') diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index a11a87f93a..7cdaab4f11 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -22,9 +22,6 @@ jobs: - name: Checkout repository uses: actions/checkout@v3 - - name: Setup common environment variables - run: ./.github/workflows/env.sh - - name: Install apt packages run: ./.github/scripts/install_deps_ubuntu.sh -- cgit From 2b1c07a1d435b541c295afad13227ebb10def57e Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sun, 12 Feb 2023 18:12:17 +0100 Subject: ci: remove unnecessary matrix from codeql workflow (#22239) --- .github/workflows/codeql.yml | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) (limited to '.github/workflows/codeql.yml') diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 7cdaab4f11..657ace20fd 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -13,11 +13,6 @@ jobs: contents: read security-events: write - strategy: - fail-fast: false - matrix: - language: [ 'cpp' ] - steps: - name: Checkout repository uses: actions/checkout@v3 @@ -28,10 +23,9 @@ jobs: - name: Initialize CodeQL uses: github/codeql-action/init@v2 with: - languages: ${{ matrix.language }} + languages: cpp - - if: matrix.language == 'cpp' - run: make + - run: make - name: Perform CodeQL Analysis uses: github/codeql-action/analyze@v2 -- cgit From 5d3769ea2343a30c60963011bef85346320bd97c Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sun, 12 Feb 2023 22:09:10 +0100 Subject: ci: install dependencies with a single script (#22241) It's easier if the os-specific installations are done by the script itself --- .github/workflows/codeql.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to '.github/workflows/codeql.yml') diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 657ace20fd..c4f4346de1 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -17,8 +17,8 @@ jobs: - name: Checkout repository uses: actions/checkout@v3 - - name: Install apt packages - run: ./.github/scripts/install_deps_ubuntu.sh + - name: Install dependencies + run: cmake -P ./.github/scripts/install_dependencies.cmake - name: Initialize CodeQL uses: github/codeql-action/init@v2 -- cgit From 9de9bd4bedde734e6b795e899e78b5417bc82fe4 Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Mon, 13 Feb 2023 18:26:01 +0100 Subject: ci: replace cmake script with bash script (#22246) Bash has better error handling than cmake, and seem overall slightly more suited to scripting than cmake. --- .github/workflows/codeql.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows/codeql.yml') diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index c4f4346de1..497a79d2d1 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -18,7 +18,7 @@ jobs: uses: actions/checkout@v3 - name: Install dependencies - run: cmake -P ./.github/scripts/install_dependencies.cmake + run: ./.github/scripts/install_deps.sh - name: Initialize CodeQL uses: github/codeql-action/init@v2 -- cgit From 006152ff7aa6af65a90c1f52962447ffca848dee Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Sun, 13 Aug 2023 12:11:39 -0700 Subject: ci: run codeql on pull requests #24545 Also use cache to save 1 minute. --- .github/workflows/codeql.yml | 7 +++++++ 1 file changed, 7 insertions(+) (limited to '.github/workflows/codeql.yml') diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 497a79d2d1..61e6216377 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -1,6 +1,11 @@ name: "CodeQL" on: + push: + branches: [ "master" ] + pull_request: + # The branches below must be a subset of the branches above + branches: [ "master" ] schedule: - cron: '42 0 * * 0' workflow_dispatch: @@ -25,6 +30,8 @@ jobs: with: languages: cpp + - uses: ./.github/actions/cache + - run: make - name: Perform CodeQL Analysis -- cgit From cf7d37ad13c74461e6a05a72123ba44676e6106c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Sep 2023 12:51:40 +0000 Subject: ci: bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/codeql.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows/codeql.yml') diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index 61e6216377..a29ea46027 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -20,7 +20,7 @@ jobs: steps: - name: Checkout repository - uses: actions/checkout@v3 + uses: actions/checkout@v4 - name: Install dependencies run: ./.github/scripts/install_deps.sh -- cgit From 06d48f6aa65a6694f7850246f56f208f98dcc587 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sun, 10 Sep 2023 15:21:56 +0200 Subject: ci(codeql): add concurrency to cancel unnecessary jobs early --- .github/workflows/codeql.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to '.github/workflows/codeql.yml') diff --git a/.github/workflows/codeql.yml b/.github/workflows/codeql.yml index a29ea46027..365c3fdf56 100644 --- a/.github/workflows/codeql.yml +++ b/.github/workflows/codeql.yml @@ -1,14 +1,15 @@ name: "CodeQL" +concurrency: + group: ${{ github.workflow }}-${{ github.event_name == 'pull_request' && github.head_ref || github.sha }} + cancel-in-progress: true + on: push: branches: [ "master" ] pull_request: # The branches below must be a subset of the branches above branches: [ "master" ] - schedule: - - cron: '42 0 * * 0' - workflow_dispatch: jobs: analyze: name: Analyze -- cgit