From eb3f8989a01cce538150700f7bfe75b1af23bd4d Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Thu, 9 Feb 2023 23:23:48 +0100 Subject: ci(lintcommit): turn off debug tracing (#22196) The default output is too verbose and messy for someone not already familiar with lintcommit, which defeats it purpose. --- .github/workflows/lintcommit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows/lintcommit.yml') diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index a7a227865d..9941a01a9b 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -20,4 +20,4 @@ jobs: with: neovim: true - run: wget https://raw.githubusercontent.com/neovim/neovim/master/scripts/lintcommit.lua - - run: nvim --clean -es +"cd pr_nvim" +"lua dofile('../lintcommit.lua').main({trace=true})" + - run: nvim --clean -es +"cd pr_nvim" +"lua dofile('../lintcommit.lua').main({trace=false})" -- cgit From b0d156c00b3900c8e40cf7f0e76c34b734d50598 Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sat, 11 Feb 2023 13:22:54 +0100 Subject: ci: run lintcommit file from PR branch (#22219) As the trigger type is no longer pull_request_target there is no longer any risk of using the lintcommit script directly from the user PR. --- .github/workflows/lintcommit.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to '.github/workflows/lintcommit.yml') diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index 9941a01a9b..afedbe0b12 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -15,9 +15,7 @@ jobs: with: fetch-depth: 0 ref: ${{ github.event.pull_request.head.sha }} - path: pr_nvim - uses: rhysd/action-setup-vim@v1 with: neovim: true - - run: wget https://raw.githubusercontent.com/neovim/neovim/master/scripts/lintcommit.lua - - run: nvim --clean -es +"cd pr_nvim" +"lua dofile('../lintcommit.lua').main({trace=false})" + - run: nvim --clean -es +"lua require('scripts.lintcommit').main({trace=false})" -- cgit From 55d346fc2683a18256320eaae75eb4f3137dcced Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sun, 16 Apr 2023 14:16:19 +0200 Subject: ci: remove unnecessary token usage --- .github/workflows/lintcommit.yml | 2 -- 1 file changed, 2 deletions(-) (limited to '.github/workflows/lintcommit.yml') diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index afedbe0b12..77c75fbd76 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -8,8 +8,6 @@ jobs: lint-commits: runs-on: ubuntu-latest if: github.event.pull_request.draft == false - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} steps: - uses: actions/checkout@v3 with: -- cgit From 732cb9e1e0a90f40d9189bffe009bbb7f8456eeb Mon Sep 17 00:00:00 2001 From: Lewis Russell Date: Sat, 22 Apr 2023 14:10:35 +0100 Subject: ci(lintcommit): use nvim -l --- .github/workflows/lintcommit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows/lintcommit.yml') diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index 77c75fbd76..71a7ad1462 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -16,4 +16,4 @@ jobs: - uses: rhysd/action-setup-vim@v1 with: neovim: true - - run: nvim --clean -es +"lua require('scripts.lintcommit').main({trace=false})" + - run: nvim --clean -l scripts/lintcommit.lua main --notrace -- cgit From ccce200cde296aa65a720e028a5eacf715f29e4f Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sat, 22 Apr 2023 17:37:45 +0200 Subject: ci(lintcommit): fix error output Using print() alone doesn't work properly, toggling the verbose option is still required. --- .github/workflows/lintcommit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows/lintcommit.yml') diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index 71a7ad1462..0bd92c05ec 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -16,4 +16,4 @@ jobs: - uses: rhysd/action-setup-vim@v1 with: neovim: true - - run: nvim --clean -l scripts/lintcommit.lua main --notrace + - run: nvim --clean -l scripts/lintcommit.lua main -- cgit From 13a24b905e1646767fed908b8dbdb535a65414ab Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Sat, 29 Apr 2023 14:30:54 +0200 Subject: ci: run lintcommit with cmake target This increases CI time, but prevents situations where it works on CI but not locally. --- .github/workflows/lintcommit.yml | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) (limited to '.github/workflows/lintcommit.yml') diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index 0bd92c05ec..e56211c29b 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -13,7 +13,15 @@ jobs: with: fetch-depth: 0 ref: ${{ github.event.pull_request.head.sha }} - - uses: rhysd/action-setup-vim@v1 - with: - neovim: true - - run: nvim --clean -l scripts/lintcommit.lua main + + - run: ./.github/scripts/install_deps.sh + - uses: ./.github/actions/cache + - name: Build + run: | + cmake -S cmake.deps -B .deps -G Ninja + cmake --build .deps + cmake --preset ci + cmake --build build + + - name: lintcommit + run: cmake --build build --target lintcommit -- cgit From cf7d37ad13c74461e6a05a72123ba44676e6106c Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon, 4 Sep 2023 12:51:40 +0000 Subject: ci: bump actions/checkout from 3 to 4 Bumps [actions/checkout](https://github.com/actions/checkout) from 3 to 4. - [Release notes](https://github.com/actions/checkout/releases) - [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md) - [Commits](https://github.com/actions/checkout/compare/v3...v4) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] --- .github/workflows/lintcommit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows/lintcommit.yml') diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index e56211c29b..cb63ddef68 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -9,7 +9,7 @@ jobs: runs-on: ubuntu-latest if: github.event.pull_request.draft == false steps: - - uses: actions/checkout@v3 + - uses: actions/checkout@v4 with: fetch-depth: 0 ref: ${{ github.event.pull_request.head.sha }} -- cgit From 9ad239690fe6b151afe2f43c2858d68a2b877e1d Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sun, 22 Oct 2023 13:30:32 +0200 Subject: ci: various fixes - adjust reviewers - add workflow as cache key - install attr only when tesitng - fix s390x workflow by checking out the merge PR instead of master --- .github/workflows/lintcommit.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows/lintcommit.yml') diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index cb63ddef68..8f56c057ae 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -18,7 +18,7 @@ jobs: - uses: ./.github/actions/cache - name: Build run: | - cmake -S cmake.deps -B .deps -G Ninja + cmake -S cmake.deps --preset ci cmake --build .deps cmake --preset ci cmake --build build -- cgit