From f70af5c3cad098ee9c7f1956bc18991cbd515507 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Mon, 27 May 2024 18:42:45 +0200 Subject: ci: bump backport action to version 3 --- .github/workflows/backport.yml | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml index 9fbe837106..16ed889841 100644 --- a/.github/workflows/backport.yml +++ b/.github/workflows/backport.yml @@ -14,15 +14,10 @@ jobs: - uses: actions/checkout@v4 - name: Create backport PR id: backport - uses: korthout/backport-action@v2 + uses: korthout/backport-action@v3 with: pull_title: "${pull_title}" label_pattern: "^ci:backport ([^ ]+)$" - # https://github.com/korthout/backport-action/pull/399 - experimental: > - { - "detect_merge_method": true - } - if: ${{steps.backport.outputs.was_successful == 'true'}} uses: actions/github-script@v7 -- cgit From 3c803483ac0db09fe4fd9dc81f618e7a247714cc Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sun, 14 Jul 2024 17:24:40 +0200 Subject: ci: adjust workflows to enable required checks Auto-merging is a useful feature by github, but it requires required checks which requires a few adjustments. The primary change is that required checks can't use `paths` or `paths-ignore` as that risks not running the job, and required checks must always be run. A workaround for this is to introduce a dummy workflow which is used for every path not used in the real workflow. That way the required job is "always" run as far as github is concerned. The workaround is unweildly so it's only useful to do it for costly workflows where the potential benefits are big. If not it's better to simply remove any `paths` or `paths-ignore` from a workflow instead. --- .github/workflows/build_dummy.yml | 33 +++++++++++++++++++++++++++++++++ .github/workflows/docs.yml | 7 ------- .github/workflows/test.yml | 21 ++++++++++++--------- 3 files changed, 45 insertions(+), 16 deletions(-) create mode 100644 .github/workflows/build_dummy.yml (limited to '.github/workflows') diff --git a/.github/workflows/build_dummy.yml b/.github/workflows/build_dummy.yml new file mode 100644 index 0000000000..b499ba7fa2 --- /dev/null +++ b/.github/workflows/build_dummy.yml @@ -0,0 +1,33 @@ +name: build_dummy +on: + pull_request: + branches: + - 'master' + - 'release-[0-9]+.[0-9]+' + # This needs to be an exact complement of `paths` in the build.yml workflow. + # This is required to bypass required checks since a required job is always + # needed to run. + paths-ignore: + - '**.cmake' + - '**/CMakeLists.txt' + - '**/CMakePresets.json' + - 'cmake.*/**' + - '.github/**' + +concurrency: + group: ${{ github.workflow }}-${{ github.ref }} + cancel-in-progress: ${{ github.event_name == 'pull_request' }} + +jobs: + old-cmake: + name: Test oldest supported cmake + runs-on: ubuntu-latest + timeout-minutes: 15 + steps: + - run: echo "success" + + use-existing-src: + name: Test USE_EXISTING_SRC_DIR=ON builds with no network access + runs-on: ubuntu-latest + steps: + - run: echo "success" diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml index c91f2945fb..f132404382 100644 --- a/.github/workflows/docs.yml +++ b/.github/workflows/docs.yml @@ -2,13 +2,6 @@ name: docs on: pull_request: types: [opened, synchronize, reopened, ready_for_review] - paths: - - 'src/nvim/api/*.[ch]' - - 'src/nvim/eval.lua' - - 'runtime/lua/**.lua' - - 'runtime/doc/**' - - 'scripts/gen_vimdoc.py' - - 'scripts/gen_help_html.lua' jobs: docs: runs-on: ubuntu-latest diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d0ee18ab73..b6767e71b1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -8,8 +8,6 @@ on: branches: - 'master' - 'release-[0-9]+.[0-9]+' - paths-ignore: - - 'contrib/**' workflow_dispatch: concurrency: @@ -95,18 +93,23 @@ jobs: - run: cmake --build build --target clang-analyzer posix: - name: ${{ matrix.build.runner }} ${{ matrix.build.flavor }} ${{ matrix.build.cc }} ${{ matrix.test }} + name: ${{ matrix.build.os }} ${{ matrix.build.flavor }} ${{ matrix.build.cc }} ${{ matrix.test }} strategy: fail-fast: false matrix: + # The `os` field is not needed to differentiate between the different + # matrix builds. It is needed to not change the required checks (which + # uses jobs names) each time we bump the runner version. It may be + # possible to remove if we e.g. start using `-latest` runner versions + # or if github introduces a wildcard for required checks in the future. build: [ - { runner: ubuntu-22.04, flavor: asan, cc: clang, flags: -D ENABLE_ASAN_UBSAN=ON }, - { runner: ubuntu-22.04, flavor: tsan, cc: clang, flags: -D ENABLE_TSAN=ON }, - { runner: ubuntu-22.04, cc: gcc }, - { runner: macos-12, cc: clang, flags: -D CMAKE_FIND_FRAMEWORK=NEVER, deps_flags: -D CMAKE_FIND_FRAMEWORK=NEVER }, - { runner: macos-14, cc: clang, flags: -D CMAKE_FIND_FRAMEWORK=NEVER, deps_flags: -D CMAKE_FIND_FRAMEWORK=NEVER }, - { runner: ubuntu-22.04, flavor: puc-lua, cc: gcc, deps_flags: -D USE_BUNDLED_LUAJIT=OFF -D USE_BUNDLED_LUA=ON, flags: -D PREFER_LUA=ON }, + { runner: ubuntu-22.04, os: ubuntu, flavor: asan, cc: clang, flags: -D ENABLE_ASAN_UBSAN=ON }, + { runner: ubuntu-22.04, os: ubuntu, flavor: tsan, cc: clang, flags: -D ENABLE_TSAN=ON }, + { runner: ubuntu-22.04, os: ubuntu, cc: gcc }, + { runner: macos-12, os: macos, flavor: 12, cc: clang, flags: -D CMAKE_FIND_FRAMEWORK=NEVER, deps_flags: -D CMAKE_FIND_FRAMEWORK=NEVER }, + { runner: macos-14, os: macos, cc: clang, flags: -D CMAKE_FIND_FRAMEWORK=NEVER, deps_flags: -D CMAKE_FIND_FRAMEWORK=NEVER }, + { runner: ubuntu-22.04, os: ubuntu, flavor: puc-lua, cc: gcc, deps_flags: -D USE_BUNDLED_LUAJIT=OFF -D USE_BUNDLED_LUA=ON, flags: -D PREFER_LUA=ON }, ] test: [unittest, functionaltest, oldtest] exclude: -- cgit From a5d4e3467d4568e5ac804f8178dda054f5360b15 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Tue, 16 Jul 2024 12:51:53 +0200 Subject: ci: run workflows on release branches Github doesn't allow workflows to be run from the `github-actions` account, which is the default account. This caused the CI on backport PRs to not be run. The way to circumvent this is to use a token that essentially "pretends" to be another user, which in turn triggers the CI as desired. Also run lintcommit on release branches as that is now a required check, meaning it must always be run. --- .github/workflows/backport.yml | 8 ++++++++ .github/workflows/lintcommit.yml | 1 + 2 files changed, 9 insertions(+) (limited to '.github/workflows') diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml index 16ed889841..de62ffb59d 100644 --- a/.github/workflows/backport.yml +++ b/.github/workflows/backport.yml @@ -12,12 +12,20 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v4 + + - uses: actions/create-github-app-token@v1 + id: app-token + with: + app-id: ${{ vars.BACKPORT_APP }} + private-key: ${{ secrets.BACKPORT_KEY }} + - name: Create backport PR id: backport uses: korthout/backport-action@v3 with: pull_title: "${pull_title}" label_pattern: "^ci:backport ([^ ]+)$" + github_token: ${{ steps.app-token.outputs.token }} - if: ${{steps.backport.outputs.was_successful == 'true'}} uses: actions/github-script@v7 diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index 3d140532cd..aa56de6d6a 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -4,6 +4,7 @@ on: types: [opened, synchronize, reopened, ready_for_review] branches: - 'master' + - 'release-[0-9]+.[0-9]+' jobs: lint-commits: runs-on: ubuntu-latest -- cgit From dafd944a465c576a86cfa34cc7f7a5e18a39b8e7 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Wed, 17 Jul 2024 12:38:34 +0200 Subject: ci: remove "skip ci" tag We can't skip CI runs as there are required checks that needs to always be run. --- .github/workflows/vim_patches.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows') diff --git a/.github/workflows/vim_patches.yml b/.github/workflows/vim_patches.yml index f4251336c7..b0be01089f 100644 --- a/.github/workflows/vim_patches.yml +++ b/.github/workflows/vim_patches.yml @@ -50,6 +50,6 @@ jobs: if: ${{ steps.update-version.outputs.NEW_PATCHES != 0 }} run: | git add -u - git commit -m 'docs: update version.c [skip ci]' + git commit -m 'docs: update version.c' git push --force https://${GITHUB_ACTOR}:${GITHUB_TOKEN}@github.com/${GITHUB_REPOSITORY} ${VERSION_BRANCH} gh pr create --draft --fill --label vim-patch --base ${GITHUB_REF#refs/heads/} --head ${VERSION_BRANCH} || true -- cgit From 0500804df52c64bd250a75ed94f4c414a85ca52b Mon Sep 17 00:00:00 2001 From: dundargoc Date: Wed, 17 Jul 2024 15:54:09 +0200 Subject: ci: skip lintcommit workflow on release branches Since lintcommit is a required check, it will always need to be run. However, the lintcommit script is not designed to work on PRs that doesn't target master branch (and it's not clear whether it's even desirable). To circumvent this we create a "dummy" lintcommit check that is run on release branches that always passes, thus fulfilling the condition of the required check. --- .github/workflows/lintcommit.yml | 3 +-- .github/workflows/lintcommit_dummy.yml | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/lintcommit_dummy.yml (limited to '.github/workflows') diff --git a/.github/workflows/lintcommit.yml b/.github/workflows/lintcommit.yml index aa56de6d6a..49dc7f3e66 100644 --- a/.github/workflows/lintcommit.yml +++ b/.github/workflows/lintcommit.yml @@ -1,10 +1,9 @@ -name: "lintcommit" +name: lintcommit on: pull_request: types: [opened, synchronize, reopened, ready_for_review] branches: - 'master' - - 'release-[0-9]+.[0-9]+' jobs: lint-commits: runs-on: ubuntu-latest diff --git a/.github/workflows/lintcommit_dummy.yml b/.github/workflows/lintcommit_dummy.yml new file mode 100644 index 0000000000..e4a0c4af2d --- /dev/null +++ b/.github/workflows/lintcommit_dummy.yml @@ -0,0 +1,16 @@ +# Dummy workflow of lintcommit.yml. lintcommit is a required check, but it's +# only designed to work on master. Since required checks are always required to +# run, we can essentially "skip" the lintcommit on release branches with this +# dummy check that automatically passes. +name: lintcommit_dummy +on: + pull_request: + types: [opened, synchronize, reopened, ready_for_review] + branches: + - 'release-[0-9]+.[0-9]+' +jobs: + lint-commits: + runs-on: ubuntu-latest + if: github.event.pull_request.draft == false + steps: + - run: echo "success" -- cgit From 4c788b175743e54d0a73248c820d6cf16a854f6e Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sun, 21 Jul 2024 14:55:34 +0200 Subject: ci: always add `target:release` label when backporting Previously the label was not added if the backport PR was created manually. The new code is also easier to maintain as it's close to other label-related code. --- .github/workflows/backport.yml | 11 ----------- .github/workflows/labeler_pr.yml | 19 ++++++++++++++++++- 2 files changed, 18 insertions(+), 12 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml index de62ffb59d..0c3ba6be34 100644 --- a/.github/workflows/backport.yml +++ b/.github/workflows/backport.yml @@ -26,14 +26,3 @@ jobs: pull_title: "${pull_title}" label_pattern: "^ci:backport ([^ ]+)$" github_token: ${{ steps.app-token.outputs.token }} - - - if: ${{steps.backport.outputs.was_successful == 'true'}} - uses: actions/github-script@v7 - with: - script: | - github.rest.issues.addLabels({ - issue_number: ${{steps.backport.outputs.created_pull_numbers}}, - owner: context.repo.owner, - repo: context.repo.repo, - labels: ['target:release'] - }) diff --git a/.github/workflows/labeler_pr.yml b/.github/workflows/labeler_pr.yml index 8fd93bfb6d..5d402c3c03 100644 --- a/.github/workflows/labeler_pr.yml +++ b/.github/workflows/labeler_pr.yml @@ -33,8 +33,25 @@ jobs: - name: "Extract if the PR is a breaking change and add it as label" run: gh pr edit "$PR_NUMBER" --add-label "$(echo "$PR_TITLE" | sed -E 's|[[:alpha:]]+(\(.*\))?!:.*|breaking-change|')" || true - request-reviewer: + target-release: needs: ["changed-files", "type-scope"] + runs-on: ubuntu-latest + permissions: + pull-requests: write + steps: + - if: startsWith(github.base_ref, 'release') + uses: actions/github-script@v7 + with: + script: | + github.rest.issues.addLabels({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + labels: ['target:release'] + }) + + request-reviewer: + needs: ["changed-files", "type-scope", "target-release"] permissions: pull-requests: write uses: ./.github/workflows/reviewers_add.yml -- cgit From 1247684ae14e83c5b742be390de8dee00fd4e241 Mon Sep 17 00:00:00 2001 From: bfredl Date: Tue, 2 Jul 2024 13:47:04 +0200 Subject: build(deps): remove msgpack-c dependency --- .github/workflows/test.yml | 1 - 1 file changed, 1 deletion(-) (limited to '.github/workflows') diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index b6767e71b1..4759426bb4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -241,7 +241,6 @@ jobs: sudo add-apt-repository ppa:neovim-ppa/stable sudo apt-get install -y \ libluajit-5.1-dev \ - libmsgpack-dev \ libtermkey-dev \ libunibilium-dev \ libuv1-dev \ -- cgit From b3641b80083d395b322fa2c5c84ed67f39cd76cd Mon Sep 17 00:00:00 2001 From: Gregory Anders Date: Mon, 5 Aug 2024 11:31:48 -0500 Subject: build(deps): remove libtermkey dependency It's been vendored since https://github.com/neovim/neovim/pull/25870. --- .github/workflows/test.yml | 1 - 1 file changed, 1 deletion(-) (limited to '.github/workflows') diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 4759426bb4..55319bb012 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -241,7 +241,6 @@ jobs: sudo add-apt-repository ppa:neovim-ppa/stable sudo apt-get install -y \ libluajit-5.1-dev \ - libtermkey-dev \ libunibilium-dev \ libuv1-dev \ lua-filesystem \ -- cgit From 9307a53c7bc30f9d17b6ab97e90d8a1b5fc313b2 Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Wed, 7 Aug 2024 06:53:05 +0800 Subject: vim-patch:9.1.0661: the zip plugin is not tested. (#29993) Problem: the zip plugin is not tested. Solution: include tests (Damien) closes: vim/vim#15411 https://github.com/vim/vim/commit/d7af21e746f3992c650caf6b76465880b96302b4 Co-authored-by: Damien <141588647+xrandomname@users.noreply.github.com> --- .github/workflows/test_windows.yml | 1 + 1 file changed, 1 insertion(+) (limited to '.github/workflows') diff --git a/.github/workflows/test_windows.yml b/.github/workflows/test_windows.yml index d92993a08c..db7ad93f55 100644 --- a/.github/workflows/test_windows.yml +++ b/.github/workflows/test_windows.yml @@ -60,6 +60,7 @@ jobs: uses: msys2/setup-msys2@v2 with: update: true + install: unzip pacboy: >- make:p gcc:p diffutils:p release: false -- cgit From fa79a8ad6deefeea81c1959d69aa4c8b2d993f99 Mon Sep 17 00:00:00 2001 From: Christian Clason Date: Thu, 8 Aug 2024 12:28:47 +0200 Subject: build(deps): vendor libvterm at v0.3.3 Problem: Adding support for modern Nvim features (reflow, OSC 8, full utf8/emoji support) requires coupling libvterm to Nvim internals (e.g., utf8proc). Solution: Vendor libvterm at v0.3.3. --- .github/workflows/test.yml | 1 - 1 file changed, 1 deletion(-) (limited to '.github/workflows') diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 55319bb012..ef921cc3a4 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -248,7 +248,6 @@ jobs: luajit \ lua-luv-dev # libtree-sitter-dev \ - # libvterm-dev # Remove comments from packages once we start using these external # dependencies. -- cgit From 688b961d13bd54a14836f08c3ded3121d3fb15a0 Mon Sep 17 00:00:00 2001 From: Lewis Russell Date: Fri, 19 Apr 2024 16:04:57 +0100 Subject: feat(treesitter): add support for wasm parsers Problem: Installing treesitter parser is hard (harder than climbing to heaven). Solution: Add optional support for wasm parsers with `wasmtime`. Notes: * Needs to be enabled by setting `ENABLE_WASMTIME` for tree-sitter and Neovim. Build with `make CMAKE_EXTRA_FLAGS=-DENABLE_WASMTIME=ON DEPS_CMAKE_FLAGS=-DENABLE_WASMTIME=ON` * Adds optional Rust (obviously) and C11 dependencies. * Wasmtime comes with a lot of features that can negatively affect Neovim performance due to library and symbol table size. Make sure to build with minimal features and full LTO. * To reduce re-compilation times, install `sccache` and build with `RUSTC_WRAPPER= make ...` --- .github/workflows/build.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) (limited to '.github/workflows') diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a2316f3f0f..e77485210e 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -21,6 +21,21 @@ env: INSTALL_PREFIX: ${{ github.workspace }}/nvim-install jobs: + wasmtime: + strategy: + fail-fast: false + matrix: + test: [ubuntu-latest, macos-latest, windows-latest] + runs-on: ${{ matrix.test }} + steps: + - uses: actions/checkout@v4 + - uses: ./.github/actions/setup + - run: | + cmake -S cmake.deps --preset ci -D ENABLE_WASMTIME=ON + cmake --build .deps + cmake --preset ci -D ENABLE_WASMTIME=ON + cmake --build build + old-cmake: name: Test oldest supported cmake runs-on: ubuntu-latest -- cgit From 176bfea1356bd151a8aaef61e02ac5a175969a59 Mon Sep 17 00:00:00 2001 From: bfredl Date: Mon, 8 Jan 2024 14:34:49 +0100 Subject: fix(build): issues with s390x CI Does not fix everything, but at least let's test run to finish before timeout --- .github/workflows/optional.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/optional.yml b/.github/workflows/optional.yml index 742d51377f..540daccc56 100644 --- a/.github/workflows/optional.yml +++ b/.github/workflows/optional.yml @@ -11,7 +11,7 @@ concurrency: env: INSTALL_PREFIX: ${{ github.workspace }}/nvim-install # Double test timeout since it's running via qemu - TEST_TIMEOUT: 2400 + TEST_TIMEOUT: 3600 # TEST_FILE: test/functional/shada # TEST_FILTER: foo @@ -23,7 +23,7 @@ jobs: matrix: test: [functionaltest, oldtest] runs-on: ubuntu-latest - timeout-minutes: 60 + timeout-minutes: 90 steps: - run: docker run --rm --privileged multiarch/qemu-user-static:register --reset - uses: docker://multiarch/ubuntu-core:s390x-focal @@ -34,7 +34,7 @@ jobs: bash -c " apt-get -y update && - DEBIAN_FRONTEND=noninteractive apt-get -y install build-essential cmake curl gettext ninja-build locales-all cpanminus git attr libattr1-dev && + time DEBIAN_FRONTEND=noninteractive apt-get -y install build-essential cmake curl gettext ninja-build locales-all cpanminus git attr libattr1-dev xdg-utils && useradd --create-home qemuci && chown -R qemuci. . && runuser -u qemuci -- git clone --depth=1 https://github.com/neovim/neovim.git && -- cgit From 057314345a7cfc8e52bbe13a595759d6ca52ac20 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Wed, 11 Sep 2024 00:55:38 +0200 Subject: ci: enable automerge by default when backporting This will automatically merge backported PRs without human intervention if the tests pass. --- .github/workflows/backport.yml | 5 +++++ 1 file changed, 5 insertions(+) (limited to '.github/workflows') diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml index 0c3ba6be34..79d4bd115e 100644 --- a/.github/workflows/backport.yml +++ b/.github/workflows/backport.yml @@ -26,3 +26,8 @@ jobs: pull_title: "${pull_title}" label_pattern: "^ci:backport ([^ ]+)$" github_token: ${{ steps.app-token.outputs.token }} + + - name: Enable automerge + env: + GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} + run: gh pr merge --rebase --auto ${{ steps.backport.outputs.created_pull_numbers }} -- cgit From 4c23b834562f1d0587beef130c5e8ac434607358 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Fri, 13 Sep 2024 15:27:57 +0200 Subject: ci: add `needs:backport` label on backport PRs with conflict This makes it easy to keep track of which backport PRs have failed and need manual intervention to fix. --- .github/workflows/backport.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) (limited to '.github/workflows') diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml index 79d4bd115e..9c80cd85e1 100644 --- a/.github/workflows/backport.yml +++ b/.github/workflows/backport.yml @@ -27,6 +27,18 @@ jobs: label_pattern: "^ci:backport ([^ ]+)$" github_token: ${{ steps.app-token.outputs.token }} + - name: Create failed backport label + if: ${{ steps.backport.outputs.was_successful == 'false' }} + uses: actions/github-script@v7 + with: + script: | + github.rest.issues.addLabels({ + issue_number: context.issue.number, + owner: context.repo.owner, + repo: context.repo.repo, + labels: ['needs:backport'] + }) + - name: Enable automerge env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} -- cgit From 755512ed60fe6c9b7fbd3bf57c827d938ff6d743 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Fri, 13 Sep 2024 13:24:44 +0200 Subject: ci: don't add reviewers for PRs created by a bot This will ensure automatic backports created by the backport action does not request reviewers (since the commit in question has already been vetted and merged), but manual backports created by users does request reviewers as these commits has not been vetted previously. --- .github/workflows/reviewers_add.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows') diff --git a/.github/workflows/reviewers_add.yml b/.github/workflows/reviewers_add.yml index b116bca29b..90b473c754 100644 --- a/.github/workflows/reviewers_add.yml +++ b/.github/workflows/reviewers_add.yml @@ -5,7 +5,7 @@ on: workflow_call: jobs: request-reviewer: - if: github.event.pull_request.state == 'open' && github.event.pull_request.draft == false + if: github.event.pull_request.state == 'open' && github.event.pull_request.draft == false && !endsWith(github.actor, '[bot]') runs-on: ubuntu-latest permissions: pull-requests: write -- cgit From 67d6b6f27ed3016a2daf6037879d77becc2cfa8f Mon Sep 17 00:00:00 2001 From: dundargoc Date: Fri, 13 Sep 2024 16:50:08 +0200 Subject: ci: skip automerge step if backport failed --- .github/workflows/backport.yml | 1 + 1 file changed, 1 insertion(+) (limited to '.github/workflows') diff --git a/.github/workflows/backport.yml b/.github/workflows/backport.yml index 9c80cd85e1..25a52c4757 100644 --- a/.github/workflows/backport.yml +++ b/.github/workflows/backport.yml @@ -40,6 +40,7 @@ jobs: }) - name: Enable automerge + if: ${{ steps.backport.outputs.was_successful == 'true' }} env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: gh pr merge --rebase --auto ${{ steps.backport.outputs.created_pull_numbers }} -- cgit From 1d815acd78e5b961302985b80d2b625947902386 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sat, 21 Sep 2024 17:51:36 +0200 Subject: build: bump minimum cmake version to 3.16 --- .github/workflows/build.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index e77485210e..ab313729b9 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -41,8 +41,8 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 15 env: - CMAKE_URL: 'https://cmake.org/files/v3.13/cmake-3.13.0-Linux-x86_64.sh' - CMAKE_VERSION: '3.13.0' + CMAKE_URL: 'https://cmake.org/files/v3.16/cmake-3.16.0-Linux-x86_64.sh' + CMAKE_VERSION: '3.16.0' steps: - uses: actions/checkout@v4 - uses: ./.github/actions/setup -- cgit From 3f6bc34e663c62bc8899dcdc65bf204b2ccfdaec Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Tue, 24 Sep 2024 04:46:50 -0700 Subject: docs: lua error patterns #30240 Co-authored-by: Mathias Fussenegger Co-authored-by: Ananth Bhaskararaman --- .github/workflows/notes.md | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/notes.md b/.github/workflows/notes.md index f67a098687..25f4a5fb32 100644 --- a/.github/workflows/notes.md +++ b/.github/workflows/notes.md @@ -18,6 +18,8 @@ ${NVIM_VERSION} 2. Run the MSI 3. Run `nvim.exe` on your CLI of choice +Note: On Windows "Server" you may need to [install vcruntime140.dll](https://learn.microsoft.com/en-us/cpp/windows/latest-supported-vc-redist?view=msvc-170). + ### macOS (x86_64) 1. Download **nvim-macos-x86_64.tar.gz** @@ -34,11 +36,10 @@ ${NVIM_VERSION} ### Linux (x64) -Minimum glibc version to run these releases is 2.31. People requiring releases -that work on older glibc versions can find them at -https://github.com/neovim/neovim-releases. +glibc 2.31 or newer is required. Or you may try the (unsupported) [builds for older glibc](https://github.com/neovim/neovim-releases). #### AppImage + 1. Download **nvim.appimage** 2. Run `chmod u+x nvim.appimage && ./nvim.appimage` - If your system does not have FUSE you can [extract the appimage](https://github.com/AppImage/AppImageKit/wiki/FUSE#type-2-appimage): -- cgit From 0c9b3ef34dea3b957c2501601f44f1154236abf8 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Wed, 2 Oct 2024 15:16:13 +0200 Subject: ci: bump ubuntu runner version to ubuntu-24.04 Also bump clang to version 20. --- .github/workflows/test.yml | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ef921cc3a4..ce2c0540b1 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -28,7 +28,7 @@ env: jobs: lint: - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 timeout-minutes: 10 env: CC: clang @@ -78,7 +78,7 @@ jobs: run: cmake --build build --target lintc-uncrustify clang-analyzer: - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 timeout-minutes: 20 env: CC: clang @@ -104,12 +104,12 @@ jobs: # or if github introduces a wildcard for required checks in the future. build: [ - { runner: ubuntu-22.04, os: ubuntu, flavor: asan, cc: clang, flags: -D ENABLE_ASAN_UBSAN=ON }, - { runner: ubuntu-22.04, os: ubuntu, flavor: tsan, cc: clang, flags: -D ENABLE_TSAN=ON }, - { runner: ubuntu-22.04, os: ubuntu, cc: gcc }, + { runner: ubuntu-24.04, os: ubuntu, flavor: asan, cc: clang, flags: -D ENABLE_ASAN_UBSAN=ON }, + { runner: ubuntu-24.04, os: ubuntu, flavor: tsan, cc: clang, flags: -D ENABLE_TSAN=ON }, + { runner: ubuntu-24.04, os: ubuntu, cc: gcc }, { runner: macos-12, os: macos, flavor: 12, cc: clang, flags: -D CMAKE_FIND_FRAMEWORK=NEVER, deps_flags: -D CMAKE_FIND_FRAMEWORK=NEVER }, { runner: macos-14, os: macos, cc: clang, flags: -D CMAKE_FIND_FRAMEWORK=NEVER, deps_flags: -D CMAKE_FIND_FRAMEWORK=NEVER }, - { runner: ubuntu-22.04, os: ubuntu, flavor: puc-lua, cc: gcc, deps_flags: -D USE_BUNDLED_LUAJIT=OFF -D USE_BUNDLED_LUA=ON, flags: -D PREFER_LUA=ON }, + { runner: ubuntu-24.04, os: ubuntu, flavor: puc-lua, cc: gcc, deps_flags: -D USE_BUNDLED_LUAJIT=OFF -D USE_BUNDLED_LUA=ON, flags: -D PREFER_LUA=ON }, ] test: [unittest, functionaltest, oldtest] exclude: @@ -202,7 +202,7 @@ jobs: # single-config generators so it's nice to have a small sanity check for # multi-config. build-types: - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 timeout-minutes: 10 env: CC: gcc @@ -228,7 +228,7 @@ jobs: run: cmake --build build --config MinSizeRel with-external-deps: - runs-on: ubuntu-22.04 + runs-on: ubuntu-24.04 timeout-minutes: 10 env: CC: gcc -- cgit From 00d1078ede9e0f03dd5eecbc9599d39c913ab953 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sat, 5 Oct 2024 19:03:11 +0200 Subject: ci: bump macos runner version to macos-15 --- .github/workflows/test.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to '.github/workflows') diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ce2c0540b1..522692b30a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -108,7 +108,7 @@ jobs: { runner: ubuntu-24.04, os: ubuntu, flavor: tsan, cc: clang, flags: -D ENABLE_TSAN=ON }, { runner: ubuntu-24.04, os: ubuntu, cc: gcc }, { runner: macos-12, os: macos, flavor: 12, cc: clang, flags: -D CMAKE_FIND_FRAMEWORK=NEVER, deps_flags: -D CMAKE_FIND_FRAMEWORK=NEVER }, - { runner: macos-14, os: macos, cc: clang, flags: -D CMAKE_FIND_FRAMEWORK=NEVER, deps_flags: -D CMAKE_FIND_FRAMEWORK=NEVER }, + { runner: macos-15, os: macos, cc: clang, flags: -D CMAKE_FIND_FRAMEWORK=NEVER, deps_flags: -D CMAKE_FIND_FRAMEWORK=NEVER }, { runner: ubuntu-24.04, os: ubuntu, flavor: puc-lua, cc: gcc, deps_flags: -D USE_BUNDLED_LUAJIT=OFF -D USE_BUNDLED_LUA=ON, flags: -D PREFER_LUA=ON }, ] test: [unittest, functionaltest, oldtest] -- cgit