From 98876db1559c99109dc37812adb5ebccb25d9499 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Thu, 2 Mar 2023 23:15:26 +0100 Subject: ci: use the same deps directory location for all jobs Having separate directory location causes failures to be inconsistent and ultimately confusing. A common problem is a file with a particular name is searched for the entire repository, which gives different results if the dependency directory is inside the neovim directory or outside of it. --- .github/workflows/test.yml | 2 -- 1 file changed, 2 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index a702bce71f..8503eb6620 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -189,8 +189,6 @@ jobs: perl -W -e 'use Neovim::Ext; print $Neovim::Ext::VERSION' fi - - run: echo "DEPS_BUILD_DIR=$HOME/nvim-deps" >> $GITHUB_ENV - - uses: ./.github/actions/cache - name: Build third-party deps -- cgit From d877aa32f289a71062941eacab5f8950936d3089 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sun, 5 Mar 2023 14:46:17 +0100 Subject: ci: remove core dump checking from test.yml There is already a superior core dump check in test/helpers.lua, which makes this obsolete. --- .github/workflows/test.yml | 24 ------------------------ 1 file changed, 24 deletions(-) (limited to '.github/workflows') diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 8503eb6620..16bbca7050 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -268,30 +268,6 @@ jobs: name: Show logs run: cat $(find "$LOG_DIR" -type f) - - if: success() || failure() && steps.abort_job.outputs.status == 'success' - name: Show core dumps - run: | - # TODO(dundargoc): app should be luajit for unittests - app="build/bin/nvim" - if test "$RUNNER_OS" = macOS; then - cores="$(find /cores/ -type f -print)" - else - cores="$(find ./ -type f \( -name 'core.*' -o -name core -o -name nvim.core \) -print)" - fi - - if test -z "$cores"; then - exit 0 - fi - for core in $cores; do - if test "$RUNNER_OS" = macOS; then - lldb -Q -o "bt all" -f "$app" -c "$core" - else - gdb -n -batch -ex 'thread apply all bt full' "$app" -c "$core" - fi - done - echo 'Core dumps found' - exit 1 - build-types: runs-on: ubuntu-22.04 timeout-minutes: 10 -- cgit