From 73ddb6daf98d7adee2dd0dc033723383e38b0ebe Mon Sep 17 00:00:00 2001 From: dundargoc <33953936+dundargoc@users.noreply.github.com> Date: Tue, 6 Dec 2022 17:38:24 +0100 Subject: ci(news): fetch full history (#21312) We seem to need the parent commit of the earliest PR commit in order to perform common git functionality to check which files were changed. --- .github/workflows/news.yml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/news.yml b/.github/workflows/news.yml index c838c150fe..8524641b11 100644 --- a/.github/workflows/news.yml +++ b/.github/workflows/news.yml @@ -9,16 +9,15 @@ jobs: steps: - uses: actions/checkout@v3 with: - ref: ${{ github.event.pull_request.head.sha }} - fetch-depth: ${{ github.event.pull_request.commits }} + fetch-depth: 0 - name: news.txt needs to be updated run: | - for commit in $(git rev-list HEAD); do + for commit in $(git rev-list HEAD~${{ github.event.pull_request.commits }}..HEAD); do message=$(git log -n1 --pretty=format:%s $commit) type="$(echo "$message" | sed -E 's|([[:alpha:]]+)(\(.*\))?!?:.*|\1|')" breaking="$(echo "$message" | sed -E 's|[[:alpha:]]+(\(.*\))?!:.*|breaking-change|')" if [[ "$type" == "feat" ]] || [[ "$breaking" == "breaking-change" ]]; then - git diff HEAD~$((${{ github.event.pull_request.commits }}-1)) --name-only | grep runtime/doc/news.txt || + ! git diff HEAD~${{ github.event.pull_request.commits }}..HEAD --quiet runtime/doc/news.txt || { echo " Pull request includes a new feature or a breaking change, but -- cgit