From 8728ba3951a67b293feeefe29b5ccd757d11c42f Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Mon, 25 Sep 2023 05:47:55 +0800 Subject: vim-patch:9.0.1931: make test_compilers fails on ubuntu MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem: make test_compilers fails on ubuntu Solution: set LC_ALL=C fix: make test_compiler failed on xubuntu 22.04.3 Problem: 'make test_compiler' failed on Linux xubuntu 22.04.3 but succeeded on e.g. macOS. To reproduce: ``` $ ./configure --with-features=huge --enable-gui=no --enable-perlinterp=yes $ make -j12 $ cd vim/src/testdir $ make test_compiler ...snip... Found errors in Test_compiler(): command line..script /home/dope/sb/vim/src/testdir/runtest.vim[601]..function RunTheTest[54]..Test_compiler line 24: command did not fail: clist command line..script /home/dope/sb/vim/src/testdir/runtest.vim[601]..function RunTheTest[54]..Test_compiler line 30: Pattern '\\n \\d\\+ Xfoo.pl:3: Global symbol "$foo" requires explicit package name' does not match '\n19 Xfoo.pl:3: Global symbol "$foo" requires explicit package name (did you forget to declare "my $foo"?)' make: *** [Makefile:70: test_compiler] Error 1 ``` Solution: set `LC_ALL` to "C" in `Test_compiler()` closes: vim/vim#13173 https://github.com/vim/vim/commit/ca0ffc0d63727850c520a80929698e4c199b17f4 Co-authored-by: Dominique Pellé --- test/old/testdir/test_compiler.vim | 11 +++++------ test/old/testdir/test_syntax.vim | 6 +++--- 2 files changed, 8 insertions(+), 9 deletions(-) diff --git a/test/old/testdir/test_compiler.vim b/test/old/testdir/test_compiler.vim index ec7d143030..0b22bafabb 100644 --- a/test/old/testdir/test_compiler.vim +++ b/test/old/testdir/test_compiler.vim @@ -7,10 +7,8 @@ func Test_compiler() CheckExecutable perl CheckFeature quickfix - " $LANG changes the output of Perl. - if $LANG != '' - unlet $LANG - endif + let save_LC_ALL = $LC_ALL + let $LC_ALL= "C" " %:S does not work properly with 'shellslash' set let save_shellslash = &shellslash @@ -40,12 +38,13 @@ func Test_compiler() let &shellslash = save_shellslash call delete('Xfoo.pl') bw! + let $LC_ALL = save_LC_ALL endfunc func GetCompilerNames() return glob('$VIMRUNTIME/compiler/*.vim', 0, 1) - \ ->map({i, v -> substitute(v, '.*[\\/]\([a-zA-Z0-9_\-]*\).vim', '\1', '')}) - \ ->sort() + \ ->map({i, v -> substitute(v, '.*[\\/]\([a-zA-Z0-9_\-]*\).vim', '\1', '')}) + \ ->sort() endfunc func Test_compiler_without_arg() diff --git a/test/old/testdir/test_syntax.vim b/test/old/testdir/test_syntax.vim index c9ad4bb857..76a21adc57 100644 --- a/test/old/testdir/test_syntax.vim +++ b/test/old/testdir/test_syntax.vim @@ -41,9 +41,9 @@ func AssertHighlightGroups(lnum, startcol, expected, trans = 1, msg = "") for l:i in range(a:startcol, a:startcol + l:expectedGroups->len() - 1) let l:errors += synID(a:lnum, l:i, a:trans) - \ ->synIDattr("name") - \ ->assert_equal(l:expectedGroups[l:i - 1], - \ l:msg .. l:i) + \ ->synIDattr("name") + \ ->assert_equal(l:expectedGroups[l:i - 1], + \ l:msg .. l:i) endfor endfunc -- cgit