From d3e0d299192b7db07445db2fcdcbe089e1cf08f1 Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Fri, 18 Sep 2020 21:38:51 -0400 Subject: vim-patch:8.2.0824: still not enough memory allocated when converting string Problem: Still not enough memory allocated when converting string with special character. Solution: Reserve space for expanding K_SPECIAL. (closes vim/vim#6130) https://github.com/vim/vim/commit/1919371b2b9ddb1a645f40b59adbd89317530882 --- src/nvim/eval.c | 7 ++++--- src/nvim/testdir/test_functions.vim | 1 + 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/nvim/eval.c b/src/nvim/eval.c index f3b6818464..00542e3766 100644 --- a/src/nvim/eval.c +++ b/src/nvim/eval.c @@ -4527,10 +4527,11 @@ static int get_string_tv(char_u **arg, typval_T *rettv, int evaluate) if (*p == '\\' && p[1] != NUL) { p++; // A "\" form occupies at least 4 characters, and produces up - // to 9 characters (6 for the char and 3 for a modifier): reserve - // space for 5 extra. + // to 21 characters (3 * 6 for the char and 3 for a modifier): + // reserve space for 18 extra. + // Each byte in the char could be encoded as K_SPECIAL K_EXTRA x. if (*p == '<') { - extra += 5; + extra += 18; } } } diff --git a/src/nvim/testdir/test_functions.vim b/src/nvim/testdir/test_functions.vim index c8140d1c52..c29e0410a9 100644 --- a/src/nvim/testdir/test_functions.vim +++ b/src/nvim/testdir/test_functions.vim @@ -1374,6 +1374,7 @@ func Test_nr2char() call assert_equal('a', nr2char(97, 0)) call assert_equal("\x80\xfc\b\xf4\x80\xfeX\x80\xfeX\x80\xfeX", eval('"\"')) + call assert_equal("\x80\xfc\b\xfd\x80\xfeX\x80\xfeX\x80\xfeX\x80\xfeX\x80\xfeX", eval('"\"')) endfunc " vim: shiftwidth=2 sts=2 expandtab -- cgit