From 63e67468b45edcc899de24a1940985bccf68f66a Mon Sep 17 00:00:00 2001
From: dundargoc <33953936+dundargoc@users.noreply.github.com>
Date: Sun, 22 Jan 2023 18:02:02 +0100
Subject: build: use CMAKE_POSITION_INDEPENDENT_CODE instead of -fPIC (#21947)

It's simpler to let cmake figure out what flags to add to each platforms
to create position independent code rather than handling it ourselves.

Also remove code that sets POSITION_INDEPENDENT_CODE property on SHARED
and MODULE libraries, as it's already on by default.
---
 cmake.deps/cmake/BuildMsgpack.cmake | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

(limited to 'cmake.deps/cmake/BuildMsgpack.cmake')

diff --git a/cmake.deps/cmake/BuildMsgpack.cmake b/cmake.deps/cmake/BuildMsgpack.cmake
index 9d112c57b1..8347eb6170 100644
--- a/cmake.deps/cmake/BuildMsgpack.cmake
+++ b/cmake.deps/cmake/BuildMsgpack.cmake
@@ -5,13 +5,9 @@ set(MSGPACK_CMAKE_ARGS
     -DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
     -DCMAKE_GENERATOR=${CMAKE_GENERATOR}
     -DCMAKE_GENERATOR_PLATFORM=${CMAKE_GENERATOR_PLATFORM}
+    -DCMAKE_POSITION_INDEPENDENT_CODE=ON
     ${BUILD_TYPE_STRING})
 
-if(NOT MSVC)
-  list(APPEND MSGPACK_CMAKE_ARGS
-    "-DCMAKE_C_FLAGS:STRING=-fPIC")
-endif()
-
 if(USE_EXISTING_SRC_DIR)
   unset(MSGPACK_URL)
 endif()
-- 
cgit