From aa090f98015c94bf7c3fa43726f2d18fac2ae085 Mon Sep 17 00:00:00 2001 From: Daniel Hahler Date: Fri, 21 Jun 2019 03:48:46 +0200 Subject: cmake: fix usage of find_package_handle_standard_args (#10288) The package argument is case sensitive, which is important to handle X_FIND_REQUIRED properly, i.e. error out early if it is not found: CMake Error at /usr/share/cmake-3.14/Modules/FindPackageHandleStandardArgs.cmake:137 (message): Could NOT find Unibilium (missing: UNIBILIUM_LIBRARY UNIBILIUM_INCLUDE_DIR) Otherwise it would continue until: CMake Error: The following variables are used in this project, but they are set to NOTFOUND. Please set them or make sure they are set and tested correctly in the CMake files: UNIBILIUM_INCLUDE_DIR (ADVANCED) Quickly checked via `rg 'find_package_handle_standard|find_package.*REQUIRED' -I | sort`. Ref: https://gitlab.kitware.com/cmake/cmake/issues/19413 --- cmake/FindLibLUV.cmake | 2 +- cmake/FindUnibilium.cmake | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) (limited to 'cmake') diff --git a/cmake/FindLibLUV.cmake b/cmake/FindLibLUV.cmake index d8ce9264c3..619f6dfcab 100644 --- a/cmake/FindLibLUV.cmake +++ b/cmake/FindLibLUV.cmake @@ -26,7 +26,7 @@ set(LIBLUV_INCLUDE_DIRS ${LIBLUV_INCLUDE_DIR}) include(FindPackageHandleStandardArgs) # handle the QUIETLY and REQUIRED arguments and set LIBLUV_FOUND to TRUE # if all listed variables are TRUE -find_package_handle_standard_args(libluv DEFAULT_MSG +find_package_handle_standard_args(LibLUV DEFAULT_MSG LIBLUV_LIBRARY LIBLUV_INCLUDE_DIR) mark_as_advanced(LIBLUV_INCLUDE_DIR LIBLUV_LIBRARY) diff --git a/cmake/FindUnibilium.cmake b/cmake/FindUnibilium.cmake index cf0ccda877..4aa48a3d7d 100644 --- a/cmake/FindUnibilium.cmake +++ b/cmake/FindUnibilium.cmake @@ -41,7 +41,7 @@ set(UNIBILIUM_INCLUDE_DIRS ${UNIBILIUM_INCLUDE_DIR}) include(FindPackageHandleStandardArgs) # handle the QUIETLY and REQUIRED arguments and set UNIBILIUM_FOUND to TRUE # if all listed variables are TRUE -find_package_handle_standard_args(unibilium DEFAULT_MSG +find_package_handle_standard_args(Unibilium DEFAULT_MSG UNIBILIUM_LIBRARY UNIBILIUM_INCLUDE_DIR) mark_as_advanced(UNIBILIUM_INCLUDE_DIR UNIBILIUM_LIBRARY) -- cgit