From 130b5fd85f074ac5e40cb4b07c6c9dc6f91512bd Mon Sep 17 00:00:00 2001 From: Gregory Anders Date: Sat, 21 Dec 2024 08:27:27 -0600 Subject: feat(lsp): return table from lsp/ files on runtimepath (#31663) Problem: LSP configs on the runtimepath must have the same name as the LSP server and must also explicitly set the name in vim.lsp.config. This is redundant and creates a footgun where a user may accidentally use the wrong name when assigning to the vim.lsp.config table. Solution: Return a table from lsp/ runtimepath files instead --- runtime/doc/lsp.txt | 12 ++++-------- runtime/doc/news.txt | 6 ++++++ 2 files changed, 10 insertions(+), 8 deletions(-) (limited to 'runtime/doc') diff --git a/runtime/doc/lsp.txt b/runtime/doc/lsp.txt index 228bbafdd2..8b822daf9e 100644 --- a/runtime/doc/lsp.txt +++ b/runtime/doc/lsp.txt @@ -74,12 +74,8 @@ configurations, in increasing priority, from the following: 1. Configuration defined for the `'*'` name. -2. Configuration from the result of sourcing all `lsp/.lua` files - in 'runtimepath' for a server of name `name`. - - Note: because of this, calls to |vim.lsp.config()| in `lsp/*.lua` are - treated independently to other calls. This ensures configurations - defined in `lsp/*.lua` have a lower priority. +2. Configuration from the result of merging all tables returned by + `lsp/.lua` files in 'runtimepath' for a server of name `name`. 3. Configurations defined anywhere else. @@ -102,11 +98,11 @@ Given: >lua }) -- Defined in ../lsp/clangd.lua - vim.lsp.config('clangd', { + return { cmd = { 'clangd' }, root_markers = { '.clangd', 'compile_commands.json' }, filetypes = { 'c', 'cpp' }, - }) + } -- Defined in init.lua vim.lsp.config('clangd', { diff --git a/runtime/doc/news.txt b/runtime/doc/news.txt index 011970f5eb..eb04702ec2 100644 --- a/runtime/doc/news.txt +++ b/runtime/doc/news.txt @@ -22,6 +22,12 @@ EXPERIMENTS • Removed `vim.loader.disable()`. Use `vim.loader.enable(false)` instead. +LSP + +• `lsp/` runtimepath files should return a table instead of calling + |vim.lsp.config()| (or assigning to `vim.lsp.config`). See |lsp-config| + + OPTIONS • 'jumpoptions' flag "unload" has been renamed to "clean". -- cgit