From 29d5ff6ac4eade7996d14eec60a31ec6328a165d Mon Sep 17 00:00:00 2001
From: Gregory Anders <greg@gpanders.com>
Date: Wed, 13 Dec 2023 09:26:39 -0600
Subject: fix(diagnostic): check for sign namespace instead of sign group

---
 runtime/lua/vim/diagnostic.lua | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'runtime/lua/vim/diagnostic.lua')

diff --git a/runtime/lua/vim/diagnostic.lua b/runtime/lua/vim/diagnostic.lua
index 729156584f..d6db530bb0 100644
--- a/runtime/lua/vim/diagnostic.lua
+++ b/runtime/lua/vim/diagnostic.lua
@@ -897,7 +897,7 @@ M.handlers.signs = {
   end,
   hide = function(namespace, bufnr)
     local ns = M.get_namespace(namespace)
-    if ns.user_data.sign_group and api.nvim_buf_is_valid(bufnr) then
+    if ns.user_data.sign_ns and api.nvim_buf_is_valid(bufnr) then
       api.nvim_buf_clear_namespace(bufnr, ns.user_data.sign_ns, 0, -1)
     end
   end,
-- 
cgit 


From 39112c72dd3722cd4a0770fc23c9d7269a9c2283 Mon Sep 17 00:00:00 2001
From: Gregory Anders <greg@gpanders.com>
Date: Wed, 13 Dec 2023 09:43:27 -0600
Subject: docs(diagnostic): fix typo in example

---
 runtime/lua/vim/diagnostic.lua | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

(limited to 'runtime/lua/vim/diagnostic.lua')

diff --git a/runtime/lua/vim/diagnostic.lua b/runtime/lua/vim/diagnostic.lua
index d6db530bb0..1d76d1d7a0 100644
--- a/runtime/lua/vim/diagnostic.lua
+++ b/runtime/lua/vim/diagnostic.lua
@@ -598,9 +598,9 @@ end
 ---                to display in the sign column. The default is to use "E", "W", "I", and "H"
 ---                for errors, warnings, information, and hints, respectively. Example:
 ---                   <pre>lua
----                     vim.diagnostic.config({
----                       sign = { text = { [vim.diagnostic.severity.ERROR] = 'E', ... } }
----                     })
+---                       vim.diagnostic.config({
+---                         signs = { text = { [vim.diagnostic.severity.ERROR] = 'E', ... } }
+---                       })
 ---                   </pre>
 ---       - float: Options for floating windows. See |vim.diagnostic.open_float()|.
 ---       - update_in_insert: (default false) Update diagnostics in Insert mode (if false,
-- 
cgit 


From a3b39784744f330b922117655811542202fcd85b Mon Sep 17 00:00:00 2001
From: Gregory Anders <greg@gpanders.com>
Date: Wed, 13 Dec 2023 09:54:04 -0600
Subject: feat(diagnostics): support numhl and linehl for diagnostic signs

---
 runtime/lua/vim/diagnostic.lua | 9 +++++++++
 1 file changed, 9 insertions(+)

(limited to 'runtime/lua/vim/diagnostic.lua')

diff --git a/runtime/lua/vim/diagnostic.lua b/runtime/lua/vim/diagnostic.lua
index 1d76d1d7a0..0eb1ac7f15 100644
--- a/runtime/lua/vim/diagnostic.lua
+++ b/runtime/lua/vim/diagnostic.lua
@@ -602,6 +602,10 @@ end
 ---                         signs = { text = { [vim.diagnostic.severity.ERROR] = 'E', ... } }
 ---                       })
 ---                   </pre>
+---                * numhl: (table) A table mapping |diagnostic-severity| to the highlight
+---                group used for the line number where the sign is placed.
+---                * linehl: (table) A table mapping |diagnostic-severity| to the highlight group
+---                used for the whole line the sign is placed in.
 ---       - float: Options for floating windows. See |vim.diagnostic.open_float()|.
 ---       - update_in_insert: (default false) Update diagnostics in Insert mode (if false,
 ---                           diagnostics are updated on InsertLeave)
@@ -885,11 +889,16 @@ M.handlers.signs = {
       end
     end
 
+    local numhl = opts.signs.numhl or {}
+    local linehl = opts.signs.linehl or {}
+
     for _, diagnostic in ipairs(diagnostics) do
       if api.nvim_buf_is_loaded(diagnostic.bufnr) then
         api.nvim_buf_set_extmark(bufnr, ns.user_data.sign_ns, diagnostic.lnum, 0, {
           sign_text = text[diagnostic.severity] or text[M.severity[diagnostic.severity]] or 'U',
           sign_hl_group = sign_highlight_map[diagnostic.severity],
+          number_hl_group = numhl[diagnostic.severity],
+          line_hl_group = linehl[diagnostic.severity],
           priority = get_priority(diagnostic.severity),
         })
       end
-- 
cgit