From 6e8a728e3dad747d0c46dc47a530b76e8997bc08 Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sat, 25 May 2024 20:35:37 +0200 Subject: refactor: fix luals type warnings --- runtime/lua/vim/health/health.lua | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'runtime/lua/vim/health') diff --git a/runtime/lua/vim/health/health.lua b/runtime/lua/vim/health/health.lua index 5bc03199ee..235dacb82a 100644 --- a/runtime/lua/vim/health/health.lua +++ b/runtime/lua/vim/health/health.lua @@ -239,6 +239,7 @@ local function check_tmux() return end + ---@param option string local get_tmux_option = function(option) local cmd = 'tmux show-option -qvg ' .. option -- try global scope local out = vim.fn.system(vim.fn.split(cmd)) @@ -378,7 +379,7 @@ local function check_terminal() 'SSH_TTY', }) do if vim.env[env_var] then - health.info(vim.fn.printf('$%s="%s"', env_var, vim.env[env_var])) + health.info(string.format('$%s="%s"', env_var, vim.env[env_var])) end end end -- cgit From 487f44a6c14f83a4f80a4d03a4a8c16ad690927a Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Tue, 9 Jul 2024 19:17:50 +0800 Subject: fix(lua): change some vim.fn.expand() to vim.fs.normalize() (#29583) Unlike vim.fn.expand(), vim.fs.normalize() doesn't expand wildcards. --- runtime/lua/vim/health/health.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'runtime/lua/vim/health') diff --git a/runtime/lua/vim/health/health.lua b/runtime/lua/vim/health/health.lua index 235dacb82a..35b3ec17c4 100644 --- a/runtime/lua/vim/health/health.lua +++ b/runtime/lua/vim/health/health.lua @@ -50,11 +50,11 @@ local function check_config() local init_lua = vim.fn.stdpath('config') .. '/init.lua' local init_vim = vim.fn.stdpath('config') .. '/init.vim' - local vimrc = vim.env.MYVIMRC and vim.fn.expand(vim.env.MYVIMRC) or init_lua + local vimrc = vim.env.MYVIMRC and vim.fs.normalize(vim.env.MYVIMRC) or init_lua if vim.fn.filereadable(vimrc) == 0 and vim.fn.filereadable(init_vim) == 0 then ok = false - local has_vim = vim.fn.filereadable(vim.fn.expand('~/.vimrc')) == 1 + local has_vim = vim.fn.filereadable(vim.fs.normalize('~/.vimrc')) == 1 health.warn( ('%s user config file: %s'):format( -1 == vim.fn.getfsize(vimrc) and 'Missing' or 'Unreadable', @@ -114,7 +114,7 @@ local function check_config() ) shadafile = ( vim.o.shadafile == '' - and (shadafile == '' and vim.fn.stdpath('state') .. '/shada/main.shada' or vim.fn.expand( + and (shadafile == '' and vim.fn.stdpath('state') .. '/shada/main.shada' or vim.fs.normalize( shadafile )) or (vim.o.shadafile == 'NONE' and '' or vim.o.shadafile) -- cgit From 84e85aeb10ae51b03392fdee12e14c9699c99e66 Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Thu, 19 Sep 2024 06:34:23 -0700 Subject: fix(health): check more "old" files #30421 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem: Node.js provider (optional) ~ - ERROR Failed to run healthcheck for "provider.node" plugin. Exception: …/runtime/lua/provider/node/health.lua:9: attempt to call field 'provider_disabled' (a nil value) Perl provider (optional) ~ - ERROR Failed to run healthcheck for "provider.perl" plugin. Exception: …/runtime/lua/provider/perl/health.lua:8: attempt to call field 'provider_disabled' (a nil value) Python 3 provider (optional) ~ - ERROR Failed to run healthcheck for "provider.python" plugin. Exception: …/runtime/lua/provider/python/health.lua:226: attempt to call field 'provider_disabled' (a nil value) Ruby provider (optional) ~ - ERROR Failed to run healthcheck for "provider.ruby" plugin. Exception: …/runtime/lua/provider/ruby/health.lua:9: attempt to call field 'provider_disabled' (a nil value) Solution: Add these files to the runtime sanity check. fix #29302 --- runtime/lua/vim/health/health.lua | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'runtime/lua/vim/health') diff --git a/runtime/lua/vim/health/health.lua b/runtime/lua/vim/health/health.lua index 35b3ec17c4..d226f35f9a 100644 --- a/runtime/lua/vim/health/health.lua +++ b/runtime/lua/vim/health/health.lua @@ -11,10 +11,14 @@ local function check_runtime() health.start('Runtime') -- Files from an old installation. local bad_files = { - ['plugin/health.vim'] = false, ['autoload/health/nvim.vim'] = false, ['autoload/health/provider.vim'] = false, ['autoload/man.vim'] = false, + ['lua/provider/node/health.lua'] = false, + ['lua/provider/perl/health.lua'] = false, + ['lua/provider/python/health.lua'] = false, + ['lua/provider/ruby/health.lua'] = false, + ['plugin/health.vim'] = false, ['plugin/man.vim'] = false, ['queries/help/highlights.scm'] = false, ['queries/help/injections.scm'] = false, @@ -39,7 +43,7 @@ local function check_runtime() 'Found old files in $VIMRUNTIME (this can cause weird behavior):\n%s', bad_files_msg ), - { 'Delete the $VIMRUNTIME directory (or uninstall Nvim), then reinstall Nvim.' } + { 'Delete the $VIMRUNTIME directory, then reinstall Nvim.' } ) end end -- cgit