From c5119dbad633752568ea53596d2f483ee63c1ce8 Mon Sep 17 00:00:00 2001 From: Thomas Vigouroux Date: Fri, 3 Jul 2020 19:16:40 +0200 Subject: treesitter: use change calbacks on redraw --- runtime/lua/vim/tshighlighter.lua | 87 ++++++++++++++------------------------- 1 file changed, 30 insertions(+), 57 deletions(-) (limited to 'runtime/lua/vim') diff --git a/runtime/lua/vim/tshighlighter.lua b/runtime/lua/vim/tshighlighter.lua index 1440acf0d0..c1e77ea792 100644 --- a/runtime/lua/vim/tshighlighter.lua +++ b/runtime/lua/vim/tshighlighter.lua @@ -3,6 +3,7 @@ local a = vim.api -- support reload for quick experimentation local TSHighlighter = rawget(vim.treesitter, 'TSHighlighter') or {} TSHighlighter.__index = TSHighlighter +local ts_hs_ns = a.nvim_create_namespace("treesitter_hl") -- These are conventions defined by tree-sitter, though it -- needs to be user extensible also. @@ -26,7 +27,7 @@ function TSHighlighter.new(query, bufnr, ft) local self = setmetatable({}, TSHighlighter) self.parser = vim.treesitter.get_parser(bufnr, ft, function(...) self:on_change(...) end) self.buf = self.parser.bufnr - -- TODO(bfredl): perhaps on_start should be called uncondionally, instead for only on mod? + local tree = self.parser:parse() self.root = tree:root() self:set_query(query) @@ -34,10 +35,8 @@ function TSHighlighter.new(query, bufnr, ft) self.redraw_count = 0 self.line_count = {} a.nvim_buf_set_option(self.buf, "syntax", "") - a.nvim__buf_set_luahl(self.buf, { - on_start=function(...) return self:on_start(...) end, - on_window=function(...) return self:on_window(...) end, - on_line=function(...) return self:on_line(...) end, + a.nvim_buf_attach(self.buf, false, { + on_lines=function(_) self.root = self.parser:parse():root() end }) -- Tricky: if syntax hasn't been enabled, we need to reload color scheme @@ -47,6 +46,7 @@ function TSHighlighter.new(query, bufnr, ft) if vim.g.syntax_on ~= 1 then vim.api.nvim_command("runtime! syntax/synload.vim") end + return self end @@ -56,67 +56,40 @@ function TSHighlighter:set_query(query) end self.query = query - self.id_map = {} - for i, capture in ipairs(self.query.captures) do - local hl = 0 - local firstc = string.sub(capture, 1, 1) - local hl_group = self.hl_map[capture] - if firstc ~= string.lower(firstc) then - hl_group = vim.split(capture, '.', true)[1] - end - if hl_group then - hl = a.nvim_get_hl_id_by_name(hl_group) - end - self.id_map[i] = hl - end - - a.nvim__buf_redraw_range(self.buf, 0, a.nvim_buf_line_count(self.buf)) + self:on_change({{self.root:range()}}) end function TSHighlighter:on_change(changes) + -- Get a fresh root + self.root = self.parser.tree:root() + for _, ch in ipairs(changes or {}) do - a.nvim__buf_redraw_range(self.buf, ch[1], ch[3]+1) - end - self.edit_count = self.edit_count + 1 -end + -- Try to be as exact as possible + local changed_node = self.root:descendant_for_range(ch[1], ch[2], ch[3], ch[4]) -function TSHighlighter:on_start(_, _buf, _tick) - local tree = self.parser:parse() - self.root = tree:root() -end + a.nvim_buf_clear_namespace(self.buf, ts_hs_ns, ch[1], ch[3]) -function TSHighlighter:on_window(_, _win, _buf, _topline, botline) - self.iter = nil - self.nextrow = 0 - self.botline = botline - self.redraw_count = self.redraw_count + 1 -end + for capture, node in self.query:iter_captures(changed_node, self.buf, ch[1], ch[3] + 1) do + local start_row, start_col, end_row, end_col = node:range() + local capture_name = self.query.captures[capture] -function TSHighlighter:on_line(_, _win, buf, line) - if self.iter == nil then - self.iter = self.query:iter_captures(self.root,buf,line,self.botline) - end - while line >= self.nextrow do - local capture, node, match = self.iter() - local active = true - if capture == nil then - break - end - if match ~= nil then - active = self:run_pred(match) - match.active = active - end - local start_row, start_col, end_row, end_col = node:range() - local hl = self.id_map[capture] - if hl > 0 and active and end_row >= line then - a.nvim__put_attr(hl, start_row, start_col, end_row, end_col) - end - if start_row > line then - self.nextrow = start_row + local firstc = string.sub(capture_name, 1, 1) + local hl + -- TODO(vigoux): maybe we want to cache the capture -> highlight relation + if firstc ~= string.lower(firstc) then + hl = vim.split(capture_name, '.', true)[1] + else + hl = TSHighlighter.hl_map[capture_name] + end + + if hl then + a.nvim__buf_add_decoration(self.buf, ts_hs_ns, hl, + start_row, start_col, + end_row, end_col, + {}) + end end end - self.line_count[line] = (self.line_count[line] or 0) + 1 - --return tostring(self.line_count[line]) end return TSHighlighter -- cgit From 0f7eaa35551f979f4458e7a71fa14f9ef987807c Mon Sep 17 00:00:00 2001 From: Thomas Vigouroux Date: Mon, 6 Jul 2020 22:11:30 +0200 Subject: treesitter: cache the capture hl relation --- runtime/lua/vim/tshighlighter.lua | 40 +++++++++++++++++++++++++++------------ 1 file changed, 28 insertions(+), 12 deletions(-) (limited to 'runtime/lua/vim') diff --git a/runtime/lua/vim/tshighlighter.lua b/runtime/lua/vim/tshighlighter.lua index c1e77ea792..a0ff53cc00 100644 --- a/runtime/lua/vim/tshighlighter.lua +++ b/runtime/lua/vim/tshighlighter.lua @@ -46,16 +46,42 @@ function TSHighlighter.new(query, bufnr, ft) if vim.g.syntax_on ~= 1 then vim.api.nvim_command("runtime! syntax/synload.vim") end - return self end +local function is_highlight_name(capture_name) + local firstc = string.sub(capture_name, 1, 1) + return firstc ~= string.lower(firstc) +end + +function TSHighlighter:get_hl_from_capture(capture) + + local name = self.query.captures[capture] + + if is_highlight_name(name) then + -- From "Normal.left" only keep "Normal" + return vim.split(name, '.', true)[1] + else + -- Default to false to avoid recomputing + return TSHighlighter.hl_map[name] + end +end + function TSHighlighter:set_query(query) if type(query) == "string" then query = vim.treesitter.parse_query(self.parser.lang, query) end self.query = query + self.hl_cache = setmetatable({}, { + __index = function(table, capture) + local hl = self:get_hl_from_capture(capture) + rawset(table, capture, hl) + + return hl + end + }) + self:on_change({{self.root:range()}}) end @@ -71,17 +97,7 @@ function TSHighlighter:on_change(changes) for capture, node in self.query:iter_captures(changed_node, self.buf, ch[1], ch[3] + 1) do local start_row, start_col, end_row, end_col = node:range() - local capture_name = self.query.captures[capture] - - local firstc = string.sub(capture_name, 1, 1) - local hl - -- TODO(vigoux): maybe we want to cache the capture -> highlight relation - if firstc ~= string.lower(firstc) then - hl = vim.split(capture_name, '.', true)[1] - else - hl = TSHighlighter.hl_map[capture_name] - end - + local hl = self.hl_cache[capture] if hl then a.nvim__buf_add_decoration(self.buf, ts_hs_ns, hl, start_row, start_col, -- cgit From 341e139992e7bcfe02f41575ac4a9450d33dae26 Mon Sep 17 00:00:00 2001 From: Thomas Vigouroux Date: Wed, 8 Jul 2020 22:47:57 +0200 Subject: treesitter: add parser on_lines callbacks --- runtime/lua/vim/treesitter.lua | 29 ++++++++++++++++++++++------- runtime/lua/vim/tshighlighter.lua | 17 +++++++++++------ 2 files changed, 33 insertions(+), 13 deletions(-) (limited to 'runtime/lua/vim') diff --git a/runtime/lua/vim/treesitter.lua b/runtime/lua/vim/treesitter.lua index edff94af0b..927456708c 100644 --- a/runtime/lua/vim/treesitter.lua +++ b/runtime/lua/vim/treesitter.lua @@ -15,19 +15,27 @@ function Parser:parse() local changes self.tree, changes = self._parser:parse_buf(self.bufnr) self.valid = true - for _, cb in ipairs(self.change_cbs) do - cb(changes) + + if not vim.tbl_isempty(changes) then + for _, cb in ipairs(self.changedtree_cbs) do + cb(changes) + end end + return self.tree, changes end -function Parser:_on_lines(bufnr, _, start_row, old_stop_row, stop_row, old_byte_size) +function Parser:_on_lines(bufnr, changed_tick, start_row, old_stop_row, stop_row, old_byte_size) local start_byte = a.nvim_buf_get_offset(bufnr,start_row) local stop_byte = a.nvim_buf_get_offset(bufnr,stop_row) local old_stop_byte = start_byte + old_byte_size self._parser:edit(start_byte,old_stop_byte,stop_byte, start_row,0,old_stop_row,0,stop_row,0) self.valid = false + + for _, cb in ipairs(self.lines_cbs) do + cb(bufnr, changed_tick, start_row, old_stop_row, stop_row, old_byte_size) + end end function Parser:set_included_ranges(ranges) @@ -80,7 +88,8 @@ function M.create_parser(bufnr, lang, id) local self = setmetatable({bufnr=bufnr, lang=lang, valid=false}, Parser) self._parser = vim._create_ts_parser(lang) - self.change_cbs = {} + self.changedtree_cbs = {} + self.lines_cbs = {} self:parse() -- TODO(bfredl): use weakref to self, so that the parser is free'd is no plugin is -- using it. @@ -99,7 +108,7 @@ function M.create_parser(bufnr, lang, id) return self end -function M.get_parser(bufnr, ft, cb) +function M.get_parser(bufnr, ft, buf_attach_cbs) if bufnr == nil or bufnr == 0 then bufnr = a.nvim_get_current_buf() end @@ -111,9 +120,15 @@ function M.get_parser(bufnr, ft, cb) if parsers[id] == nil then parsers[id] = M.create_parser(bufnr, ft, id) end - if cb ~= nil then - table.insert(parsers[id].change_cbs, cb) + + if buf_attach_cbs and buf_attach_cbs.on_changedtree then + table.insert(parsers[id].changedtree_cbs, buf_attach_cbs.on_changedtree) + end + + if buf_attach_cbs and buf_attach_cbs.on_lines then + table.insert(parsers[id].lines_cbs, buf_attach_cbs.on_lines) end + return parsers[id] end diff --git a/runtime/lua/vim/tshighlighter.lua b/runtime/lua/vim/tshighlighter.lua index a0ff53cc00..6465751ae8 100644 --- a/runtime/lua/vim/tshighlighter.lua +++ b/runtime/lua/vim/tshighlighter.lua @@ -25,7 +25,15 @@ TSHighlighter.hl_map = { function TSHighlighter.new(query, bufnr, ft) local self = setmetatable({}, TSHighlighter) - self.parser = vim.treesitter.get_parser(bufnr, ft, function(...) self:on_change(...) end) + self.parser = vim.treesitter.get_parser( + bufnr, + ft, + { + on_changedtree = function(...) self:on_changedtree(...) end, + on_lines = function() self.root = self.parser:parse():root() end + } + ) + self.buf = self.parser.bufnr local tree = self.parser:parse() @@ -35,9 +43,6 @@ function TSHighlighter.new(query, bufnr, ft) self.redraw_count = 0 self.line_count = {} a.nvim_buf_set_option(self.buf, "syntax", "") - a.nvim_buf_attach(self.buf, false, { - on_lines=function(_) self.root = self.parser:parse():root() end - }) -- Tricky: if syntax hasn't been enabled, we need to reload color scheme -- but use synload.vim rather than syntax.vim to not enable @@ -82,10 +87,10 @@ function TSHighlighter:set_query(query) end }) - self:on_change({{self.root:range()}}) + self:on_changedtree({{self.root:range()}}) end -function TSHighlighter:on_change(changes) +function TSHighlighter:on_changedtree(changes) -- Get a fresh root self.root = self.parser.tree:root() -- cgit