From c13242cf471e9bac19672798798fbd6bb9a8125f Mon Sep 17 00:00:00 2001
From: Gregory Anders <greg@gpanders.com>
Date: Fri, 17 Sep 2021 00:17:54 -0600
Subject: fix(diagnostic): remove useless highlight links (#15683)

These links were actually defined backwards: the highlight groups
actually being used for display are the new "Diagnostic*" groups, so
linking the old "LspDiagnostics*" groups to these does absolutely
nothing, since there is nothing actually being highlighted with the
LspDiagnostics* groups.

These links were made in an attempt to preserve backward compatibility
with existing colorschemes. We could reverse the links to maintain this
preservation, but then that disallows us from actually defining default
values for the new highlight groups.

Instead, just remove the links and be done with the old LspDiagnostics*
highlight groups.

This is not technically a breaking change: the breaking change already
happened in #15585, but this PR just makes that explicit.
---
 runtime/lua/vim/lsp/diagnostic.lua | 26 --------------------------
 1 file changed, 26 deletions(-)

(limited to 'runtime/lua')

diff --git a/runtime/lua/vim/lsp/diagnostic.lua b/runtime/lua/vim/lsp/diagnostic.lua
index 01c675ba77..48c0dd92cb 100644
--- a/runtime/lua/vim/lsp/diagnostic.lua
+++ b/runtime/lua/vim/lsp/diagnostic.lua
@@ -446,14 +446,6 @@ end
 ---
 ---@deprecated Prefer |vim.diagnostic._set_signs()|
 ---
---- Sign characters can be customized with the following commands:
----
---- <pre>
---- sign define LspDiagnosticsSignError text=E texthl=LspDiagnosticsSignError linehl= numhl=
---- sign define LspDiagnosticsSignWarning text=W texthl=LspDiagnosticsSignWarning linehl= numhl=
---- sign define LspDiagnosticsSignInformation text=I texthl=LspDiagnosticsSignInformation linehl= numhl=
---- sign define LspDiagnosticsSignHint text=H texthl=LspDiagnosticsSignHint linehl= numhl=
---- </pre>
 ---@param diagnostics Diagnostic[]
 ---@param bufnr number The buffer number
 ---@param client_id number the client id
@@ -478,15 +470,6 @@ end
 ---
 ---@deprecated Prefer |vim.diagnostic._set_underline()|
 ---
---- Underline highlights can be customized by changing the following |:highlight| groups.
----
---- <pre>
---- LspDiagnosticsUnderlineError
---- LspDiagnosticsUnderlineWarning
---- LspDiagnosticsUnderlineInformation
---- LspDiagnosticsUnderlineHint
---- </pre>
----
 ---@param diagnostics Diagnostic[]
 ---@param bufnr number: The buffer number
 ---@param client_id number: The client id
@@ -506,15 +489,6 @@ end
 ---
 ---@deprecated Prefer |vim.diagnostic._set_virtual_text()|
 ---
---- Virtual text highlights can be customized by changing the following |:highlight| groups.
----
---- <pre>
---- LspDiagnosticsVirtualTextError
---- LspDiagnosticsVirtualTextWarning
---- LspDiagnosticsVirtualTextInformation
---- LspDiagnosticsVirtualTextHint
---- </pre>
----
 ---@param diagnostics Diagnostic[]
 ---@param bufnr number
 ---@param client_id number
-- 
cgit