From 353a4be7e84fdc101318215bdcc8a7e780d737fe Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sun, 12 Nov 2023 13:13:58 +0100 Subject: build: remove PVS We already have an extensive suite of static analysis tools we use, which causes a fair bit of redundancy as we get duplicate warnings. PVS is also prone to give false warnings which creates a lot of work to identify and disable. --- src/mpack/conv.c | 3 --- src/mpack/lmpack.c | 5 +---- src/mpack/mpack_core.c | 3 --- src/mpack/object.c | 3 --- src/mpack/rpc.c | 3 --- 5 files changed, 1 insertion(+), 16 deletions(-) (limited to 'src/mpack') diff --git a/src/mpack/conv.c b/src/mpack/conv.c index 6bd446ca49..c53ce1427f 100644 --- a/src/mpack/conv.c +++ b/src/mpack/conv.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include "conv.h" static int mpack_fits_single(double v); diff --git a/src/mpack/lmpack.c b/src/mpack/lmpack.c index 3c7108a337..6e693bcc5d 100644 --- a/src/mpack/lmpack.c +++ b/src/mpack/lmpack.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - /* * This module exports three classes, and each instance of those classes has its * own private registry for temporary reference storage(keeping state between @@ -246,7 +243,7 @@ static mpack_uint32_t lmpack_objlen(lua_State *L, int *is_array) } end: - if ((size_t)-1 > (mpack_uint32_t)-1 && len > (mpack_uint32_t)-1) // -V560 + if ((size_t)-1 > (mpack_uint32_t)-1 && len > (mpack_uint32_t)-1) /* msgpack spec doesn't allow lengths > 32 bits */ len = (mpack_uint32_t)-1; assert(top == lua_gettop(L)); diff --git a/src/mpack/mpack_core.c b/src/mpack/mpack_core.c index 3424f444b9..b9b92523bd 100644 --- a/src/mpack/mpack_core.c +++ b/src/mpack/mpack_core.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include "mpack_core.h" diff --git a/src/mpack/object.c b/src/mpack/object.c index 60f49f73aa..ec128690d7 100644 --- a/src/mpack/object.c +++ b/src/mpack/object.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include "object.h" diff --git a/src/mpack/rpc.c b/src/mpack/rpc.c index 2d251284ba..3b2b328065 100644 --- a/src/mpack/rpc.c +++ b/src/mpack/rpc.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include "rpc.h" -- cgit