From de21e6ef3d9af96d2b71e54d8148d28b5fc9f22e Mon Sep 17 00:00:00 2001 From: Björn Linse Date: Sun, 22 Aug 2021 16:03:21 +0200 Subject: refactor(map): remove extra-allocating map_new/map_free functions Note: the reason for removing them is not that there after this refactor is no use of them, but rather that having them available is an anti-pattern: they manange an _extra_ heap allocation which has nothing to do with the functionality of the map itself (khash manages the real buffers internally). In case there happens to be a reason to allocate the map structure itself later, this should be made explicit using xcalloc/xfree calls. --- src/nvim/api/vim.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/nvim/api/vim.c') diff --git a/src/nvim/api/vim.c b/src/nvim/api/vim.c index 5aed85ef08..90c43a1b04 100644 --- a/src/nvim/api/vim.c +++ b/src/nvim/api/vim.c @@ -63,7 +63,7 @@ void api_vim_free_all_mem(void) { String name; handle_T id; - map_foreach((&namespace_ids), name, id, { + map_foreach(&namespace_ids, name, id, { (void)id; xfree(name.data); }) @@ -1584,7 +1584,7 @@ Dictionary nvim_get_namespaces(void) String name; handle_T id; - map_foreach((&namespace_ids), name, id, { + map_foreach(&namespace_ids, name, id, { PUT(retval, name.data, INTEGER_OBJ(id)); }) -- cgit