From 47084ea7657121837536d409b9137fd38426aeef Mon Sep 17 00:00:00 2001 From: Pavel Platto Date: Sun, 13 Jul 2014 10:03:07 +0300 Subject: Use strict function prototypes #945 `-Wstrict-prototypes` warn if a function is declared or defined without specifying the argument types. This warning disallow function prototypes with empty parameter list. In C, a function declared with an empty parameter list accepts an arbitrary number of arguments when being called. This is for historic reasons; originally, C functions didn't have prototypes, as C evolved from B, a typeless language. When prototypes were added, the original typeless declarations were left in the language for backwards compatibility. Instead we should provide `void` in argument list to state that function doesn't have arguments. Also this warning disallow declaring type of the parameters after the parentheses because Neovim header generator produce no declarations for old-stlyle prototypes: it expects to find `{` after prototype. --- src/nvim/eval.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'src/nvim/eval.c') diff --git a/src/nvim/eval.c b/src/nvim/eval.c index 0a15c0b376..eafdd2446c 100644 --- a/src/nvim/eval.c +++ b/src/nvim/eval.c @@ -11649,9 +11649,7 @@ static void f_readfile(typval_T *argvars, typval_T *rettv) * Convert a List to proftime_T. * Return FAIL when there is something wrong. */ -static int list2proftime(arg, tm) -typval_T *arg; -proftime_T *tm; +static int list2proftime(typval_T *arg, proftime_T *tm) { long n1, n2; int error = FALSE; -- cgit