From c1a3d289d69b93092247e0eca3bf4b43992791a1 Mon Sep 17 00:00:00 2001 From: Marco Hinz Date: Thu, 16 Apr 2015 14:08:37 +0200 Subject: Eval: do not join a list if it's empty anyway #2441 This spares some work and also prevents list_join() from calling ga_init() with a growsize of 0 which would lead to the nvimlog being littered with: [warning @ ga_set_growsize:64] 17675 - trying to set an invalid ga_growsize: 0 Also in Vim 7.4.702 https://github.com/vim/vim/commit/5216f767d4070d0085de6fa1391e6f2991c1baa5 --- src/nvim/eval.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'src/nvim/eval.c') diff --git a/src/nvim/eval.c b/src/nvim/eval.c index 1dab9df9cb..d6a8351330 100644 --- a/src/nvim/eval.c +++ b/src/nvim/eval.c @@ -5418,6 +5418,10 @@ list_join_inner ( */ static int list_join(garray_T *gap, list_T *l, char_u *sep, int echo_style, int copyID) { + if (l->lv_len < 1) { + return OK; + } + garray_T join_ga; int retval; -- cgit