From 8ef41f590224dfeea2e51d9fec150e363fd72ee0 Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Thu, 19 Dec 2024 07:07:04 -0800 Subject: feat(jobs): jobstart(…,{term=true}), deprecate termopen() #31343 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem: `termopen` has long been a superficial wrapper around `jobstart`, and has no real purpose. Also, `vim.system` and `nvim_open_term` presumably will replace all features of `jobstart` and `termopen`, so centralizing the logic will help with that. Solution: - Introduce `eval/deprecated.c`, where all deprecated eval funcs will live. - Introduce "term" flag of `jobstart`. - Deprecate `termopen`. --- src/nvim/eval/deprecated.h | 10 ++++++++++ 1 file changed, 10 insertions(+) create mode 100644 src/nvim/eval/deprecated.h (limited to 'src/nvim/eval/deprecated.h') diff --git a/src/nvim/eval/deprecated.h b/src/nvim/eval/deprecated.h new file mode 100644 index 0000000000..b870403aa4 --- /dev/null +++ b/src/nvim/eval/deprecated.h @@ -0,0 +1,10 @@ +#pragma once + +#include // for true + +#include "nvim/eval/typval_defs.h" // IWYU pragma: keep +#include "nvim/types_defs.h" // IWYU pragma: keep + +#ifdef INCLUDE_GENERATED_DECLARATIONS +# include "eval/deprecated.h.generated.h" +#endif -- cgit From 2a7d0ed6145bf3f8b139c2694563f460f829813a Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Mon, 23 Dec 2024 05:43:52 -0800 Subject: refactor: iwyu #31637 Result of `make iwyu` (after some "fixups"). --- src/nvim/eval/deprecated.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'src/nvim/eval/deprecated.h') diff --git a/src/nvim/eval/deprecated.h b/src/nvim/eval/deprecated.h index b870403aa4..e2e3ee436e 100644 --- a/src/nvim/eval/deprecated.h +++ b/src/nvim/eval/deprecated.h @@ -1,7 +1,5 @@ #pragma once -#include // for true - #include "nvim/eval/typval_defs.h" // IWYU pragma: keep #include "nvim/types_defs.h" // IWYU pragma: keep -- cgit