From 762a8ad0f3dc93ff3d938f41af324620531b2923 Mon Sep 17 00:00:00 2001 From: Eliseo Martínez Date: Mon, 12 May 2014 12:12:27 +0200 Subject: Introduce nvim namespace: Fix unmasked strings.h issue. Problem: Now that nvim/strings.h is correctly namespaced, an issue that had been masked until now arises: When compiling, we get a lot of errors because of everywhere the functions in nvim/strings.h are used, there's no include to import them. But, how could this compile and work previously, then? It turns out that: - In every such case, we are also including vim.h, which in turn includes os_unix_defs.h. - os_unix_defs.h includes and also in some systems (e.g. OSX). - Build had been modified previously to (even when importing system headers), prefer equally-named local ones. That was in fact done as a previous attempt to solve the same issue we are trying to solve another way now. So, we were including our "strings.h" as a side-effect of including through "vim.h" --> "os_unix_defs.h". Solution: Correctly include "nvim/strings.h" in every file needing it. --- src/nvim/ops.c | 1 + 1 file changed, 1 insertion(+) (limited to 'src/nvim/ops.c') diff --git a/src/nvim/ops.c b/src/nvim/ops.c index 8f92af8725..dff9822dd0 100644 --- a/src/nvim/ops.c +++ b/src/nvim/ops.c @@ -38,6 +38,7 @@ #include "nvim/path.h" #include "nvim/screen.h" #include "nvim/search.h" +#include "nvim/strings.h" #include "nvim/term.h" #include "nvim/ui.h" #include "nvim/undo.h" -- cgit