From d9eaca99bea21829e2396b190409c33fe71bcb40 Mon Sep 17 00:00:00 2001
From: James McCoy <jamessan@jamessan.com>
Date: Thu, 6 May 2021 00:05:50 -0400
Subject: coverity/331399: Remove unused "term_name" member from PtyProcess

---
 src/nvim/os/pty_process_unix.h | 1 -
 src/nvim/os/pty_process_win.h  | 1 -
 2 files changed, 2 deletions(-)

(limited to 'src/nvim/os')

diff --git a/src/nvim/os/pty_process_unix.h b/src/nvim/os/pty_process_unix.h
index 8c822eafad..765490b92b 100644
--- a/src/nvim/os/pty_process_unix.h
+++ b/src/nvim/os/pty_process_unix.h
@@ -7,7 +7,6 @@
 
 typedef struct pty_process {
   Process process;
-  char *term_name;
   uint16_t width, height;
   struct winsize winsize;
   int tty_fd;
diff --git a/src/nvim/os/pty_process_win.h b/src/nvim/os/pty_process_win.h
index f8ec79a3d6..3f6cc58e3e 100644
--- a/src/nvim/os/pty_process_win.h
+++ b/src/nvim/os/pty_process_win.h
@@ -15,7 +15,6 @@ typedef enum {
 
 typedef struct pty_process {
   Process process;
-  char *term_name;
   uint16_t width, height;
   union {
     winpty_t *winpty;
-- 
cgit 


From efed75f91638bc52a2a551683c2f7a1da4a1e3ea Mon Sep 17 00:00:00 2001
From: James McCoy <jamessan@jamessan.com>
Date: Thu, 6 May 2021 00:08:06 -0400
Subject: coverity/331377: os_fopen: Remove invalid iflags assert

If the O_* flags were non-zero, then ORing the flags would always be
true.  However, the O_* flags aren't guaranteed to be non-zero, so the
assert is invalid in the first place.
---
 src/nvim/os/fs.c | 2 --
 1 file changed, 2 deletions(-)

(limited to 'src/nvim/os')

diff --git a/src/nvim/os/fs.c b/src/nvim/os/fs.c
index a3bef3389c..d0fa74a77f 100644
--- a/src/nvim/os/fs.c
+++ b/src/nvim/os/fs.c
@@ -471,8 +471,6 @@ FILE *os_fopen(const char *path, const char *flags)
         abort();
     }
   }
-  // Per open(2) manpage.
-  assert((iflags|O_RDONLY) || (iflags|O_WRONLY) || (iflags|O_RDWR));
   // Per fopen(3) manpage: default to 0666, it will be umask-adjusted.
   int fd = os_open(path, iflags, 0666);
   if (fd < 0) {
-- 
cgit