From 353a4be7e84fdc101318215bdcc8a7e780d737fe Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sun, 12 Nov 2023 13:13:58 +0100 Subject: build: remove PVS We already have an extensive suite of static analysis tools we use, which causes a fair bit of redundancy as we get duplicate warnings. PVS is also prone to give false warnings which creates a lot of work to identify and disable. --- src/nvim/os/dl.c | 3 --- src/nvim/os/env.c | 5 +---- src/nvim/os/fileio.c | 4 ---- src/nvim/os/fs.c | 3 --- src/nvim/os/input.c | 3 --- src/nvim/os/lang.c | 3 --- src/nvim/os/mem.c | 3 --- src/nvim/os/os_win_console.c | 3 --- src/nvim/os/process.c | 3 --- src/nvim/os/pty_conpty_win.c | 3 --- src/nvim/os/pty_process_unix.c | 3 --- src/nvim/os/pty_process_win.c | 3 --- src/nvim/os/shell.c | 3 --- src/nvim/os/signal.c | 3 --- src/nvim/os/stdpaths.c | 3 --- src/nvim/os/time.c | 3 --- src/nvim/os/tty.c | 3 --- src/nvim/os/users.c | 3 --- 18 files changed, 1 insertion(+), 56 deletions(-) (limited to 'src/nvim/os') diff --git a/src/nvim/os/dl.c b/src/nvim/os/dl.c index 519cef7876..67164f56b4 100644 --- a/src/nvim/os/dl.c +++ b/src/nvim/os/dl.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - /// Functions for using external native libraries #include diff --git a/src/nvim/os/env.c b/src/nvim/os/env.c index dbea6f01df..20dc6a159c 100644 --- a/src/nvim/os/env.c +++ b/src/nvim/os/env.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - // Environment inspection #include @@ -933,7 +930,7 @@ char *vim_getenv(const char *name) if (append_path(exe_name, "share" _PATHSEPSTR "nvim" _PATHSEPSTR "runtime" _PATHSEPSTR, MAXPATHL) == OK) { - vim_path = exe_name; // -V507 + vim_path = exe_name; } } diff --git a/src/nvim/os/fileio.c b/src/nvim/os/fileio.c index 119a42f074..ed0a97aac9 100644 --- a/src/nvim/os/fileio.c +++ b/src/nvim/os/fileio.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - /// @file fileio.c /// /// Buffered reading/writing to a file. Unlike fileio.c this is not dealing with @@ -53,7 +50,6 @@ int file_open(FileDescriptor *const ret_fp, const char *const fname, const int f { int os_open_flags = 0; TriState wr = kNone; - // -V:FLAG:501 #define FLAG(flags, flag, fcntl_flags, wrval, cond) \ do { \ if (flags & flag) { \ diff --git a/src/nvim/os/fs.c b/src/nvim/os/fs.c index 9a448d69ae..6b3f79abb2 100644 --- a/src/nvim/os/fs.c +++ b/src/nvim/os/fs.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - // fs.c -- filesystem access #include #include diff --git a/src/nvim/os/input.c b/src/nvim/os/input.c index 03418f4548..5c26a94196 100644 --- a/src/nvim/os/input.c +++ b/src/nvim/os/input.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include #include diff --git a/src/nvim/os/lang.c b/src/nvim/os/lang.c index 602dcc9bd3..d14c086a4f 100644 --- a/src/nvim/os/lang.c +++ b/src/nvim/os/lang.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #ifdef __APPLE__ # define Boolean CFBoolean // Avoid conflict with API's Boolean # define FileInfo CSFileInfo // Avoid conflict with API's Fileinfo diff --git a/src/nvim/os/mem.c b/src/nvim/os/mem.c index 0b7e8065ef..3e6264c691 100644 --- a/src/nvim/os/mem.c +++ b/src/nvim/os/mem.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - /// Functions for accessing system memory information. #include diff --git a/src/nvim/os/os_win_console.c b/src/nvim/os/os_win_console.c index 006e27d28f..af0c28a308 100644 --- a/src/nvim/os/os_win_console.c +++ b/src/nvim/os/os_win_console.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include "nvim/os/input.h" #include "nvim/os/os.h" #include "nvim/os/os_win_console.h" diff --git a/src/nvim/os/process.c b/src/nvim/os/process.c index a636689f97..889d1f453f 100644 --- a/src/nvim/os/process.c +++ b/src/nvim/os/process.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - /// OS process functions /// /// psutil is a good reference for cross-platform syscall voodoo: diff --git a/src/nvim/os/pty_conpty_win.c b/src/nvim/os/pty_conpty_win.c index 32067ad49f..819b6fcf77 100644 --- a/src/nvim/os/pty_conpty_win.c +++ b/src/nvim/os/pty_conpty_win.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include "nvim/os/os.h" diff --git a/src/nvim/os/pty_process_unix.c b/src/nvim/os/pty_process_unix.c index efd476ae7b..f3a841f7d0 100644 --- a/src/nvim/os/pty_process_unix.c +++ b/src/nvim/os/pty_process_unix.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - // Some of the code came from pangoterm and libuv #include diff --git a/src/nvim/os/pty_process_win.c b/src/nvim/os/pty_process_win.c index 763d30d4a2..19eedd14cd 100644 --- a/src/nvim/os/pty_process_win.c +++ b/src/nvim/os/pty_process_win.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include #include diff --git a/src/nvim/os/shell.c b/src/nvim/os/shell.c index 2f52895357..b3ce4a3c91 100644 --- a/src/nvim/os/shell.c +++ b/src/nvim/os/shell.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include #include diff --git a/src/nvim/os/signal.c b/src/nvim/os/signal.c index 4c4ac9df1e..e73a579a27 100644 --- a/src/nvim/os/signal.c +++ b/src/nvim/os/signal.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include #include diff --git a/src/nvim/os/stdpaths.c b/src/nvim/os/stdpaths.c index 8ea30ff21e..5aeecb8cda 100644 --- a/src/nvim/os/stdpaths.c +++ b/src/nvim/os/stdpaths.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include #include diff --git a/src/nvim/os/time.c b/src/nvim/os/time.c index ac98f0cf9a..8aa3170963 100644 --- a/src/nvim/os/time.c +++ b/src/nvim/os/time.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include #include diff --git a/src/nvim/os/tty.c b/src/nvim/os/tty.c index b5124bd83a..e683b9383f 100644 --- a/src/nvim/os/tty.c +++ b/src/nvim/os/tty.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - // // Terminal/console utils // diff --git a/src/nvim/os/users.c b/src/nvim/os/users.c index b23d2b7b13..b61dcd1e4b 100644 --- a/src/nvim/os/users.c +++ b/src/nvim/os/users.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - // users.c -- operating system user information #include -- cgit