From 488038580934f301c1528a14548ec0cabd16c2cd Mon Sep 17 00:00:00 2001
From: dundargoc <gocdundar@gmail.com>
Date: Fri, 10 Nov 2023 14:06:04 +0100
Subject: build: adjust clang-tidy warning exclusion logic

Enable all clang-tidy warnings by default instead of disabling them.
This ensures that we don't miss useful warnings on each clang-tidy
version upgrade. A drawback of this is that it will force us to either
fix or adjust the warnings as soon as possible.
---
 src/nvim/os/env.c            | 4 +---
 src/nvim/os/lang.c           | 2 +-
 src/nvim/os/os_win_console.c | 2 +-
 3 files changed, 3 insertions(+), 5 deletions(-)

(limited to 'src/nvim/os')

diff --git a/src/nvim/os/env.c b/src/nvim/os/env.c
index 20dc6a159c..ba874422ff 100644
--- a/src/nvim/os/env.c
+++ b/src/nvim/os/env.c
@@ -927,9 +927,7 @@ char *vim_getenv(const char *name)
     // Find runtime path relative to the nvim binary: ../share/nvim/runtime
     if (vim_path == NULL) {
       vim_get_prefix_from_exepath(exe_name);
-      if (append_path(exe_name,
-                      "share" _PATHSEPSTR "nvim" _PATHSEPSTR "runtime" _PATHSEPSTR,
-                      MAXPATHL) == OK) {
+      if (append_path(exe_name, "share/nvim/runtime/", MAXPATHL) == OK) {
         vim_path = exe_name;
       }
     }
diff --git a/src/nvim/os/lang.c b/src/nvim/os/lang.c
index d14c086a4f..e6db41a8ac 100644
--- a/src/nvim/os/lang.c
+++ b/src/nvim/os/lang.c
@@ -208,7 +208,7 @@ void ex_language(exarg_T *eap)
 #ifdef HAVE_NL_MSG_CAT_CNTR
       // Need to do this for GNU gettext, otherwise cached translations
       // will be used again.
-      extern int _nl_msg_cat_cntr;
+      extern int _nl_msg_cat_cntr;  // NOLINT(bugprone-reserved-identifier)
 
       _nl_msg_cat_cntr++;
 #endif
diff --git a/src/nvim/os/os_win_console.c b/src/nvim/os/os_win_console.c
index af0c28a308..44a2b6f769 100644
--- a/src/nvim/os/os_win_console.c
+++ b/src/nvim/os/os_win_console.c
@@ -80,7 +80,7 @@ void os_icon_init(void)
 
   const char *vimruntime = os_getenv("VIMRUNTIME");
   if (vimruntime != NULL) {
-    snprintf(NameBuff, MAXPATHL, "%s" _PATHSEPSTR "neovim.ico", vimruntime);
+    snprintf(NameBuff, MAXPATHL, "%s/neovim.ico", vimruntime);
     if (!os_path_exists(NameBuff)) {
       WLOG("neovim.ico not found: %s", NameBuff);
     } else {
-- 
cgit