From 138110e082e95ff82f042591c476b7479ba436e0 Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Sat, 13 Apr 2019 00:37:27 -0400 Subject: vim-patch:8.0.0683: visual bell flashes too quickly Problem: When using a visual bell there is no delay, causing the flash to be very short, possibly unnoticeable. Also, the flash and the beep can lockup the UI when repeated often. Solution: Do the delay in Vim or flush the output before the delay. Limit the bell to once per half a second. (Ozaki Kiichi, closes vim/vim#1789) https://github.com/vim/vim/commit/2e147caa14f622dfd1c1def8e07c113b9b85d4b2 --- src/nvim/misc1.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/nvim/misc1.c b/src/nvim/misc1.c index 0008409731..4fc2451788 100644 --- a/src/nvim/misc1.c +++ b/src/nvim/misc1.c @@ -2583,10 +2583,17 @@ void vim_beep(unsigned val) if (emsg_silent == 0) { if (!((bo_flags & val) || (bo_flags & BO_ALL))) { - if (p_vb) { - ui_call_visual_bell(); - } else { - ui_call_bell(); + static uint64_t start_time = 0; + + // Only beep once per half a second, otherwise a sequence of beeps + // would freeze Vim. + if (start_time == 0 || os_hrtime() - start_time > 500000000u) { + start_time = os_hrtime(); + if (p_vb) { + ui_call_visual_bell(); + } else { + ui_call_bell(); + } } } -- cgit