From ce03171323816c27737a2124f7f93a4dbfe2f48d Mon Sep 17 00:00:00 2001 From: oni-link Date: Fri, 26 Dec 2014 12:26:09 +0100 Subject: coverity/90712: Remove unnecessary check for NULL. ** CID 90712: Dereference after null check (FORWARD_NULL) /src/nvim/getchar.c: 3654 in check_abbr() vim_strsave() never returns NULL, so q is never NULL. Removing the NULL check for q should fix this warning. --- src/nvim/getchar.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src') diff --git a/src/nvim/getchar.c b/src/nvim/getchar.c index 39227cc199..d0eebf8fea 100644 --- a/src/nvim/getchar.c +++ b/src/nvim/getchar.c @@ -3645,10 +3645,8 @@ int check_abbr(int c, char_u *ptr, int col, int mincol) if (vim_strbyte(mp->m_keys, K_SPECIAL) != NULL) { /* might have CSI escaped mp->m_keys */ q = vim_strsave(mp->m_keys); - if (q != NULL) { - vim_unescape_csi(q); - qlen = (int)STRLEN(q); - } + vim_unescape_csi(q); + qlen = (int)STRLEN(q); } /* find entries with right mode and keys */ match = (mp->m_mode & State) -- cgit