From 978dd99f453c8430da4416f1fd5ca7af91b56240 Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Wed, 9 Sep 2020 22:34:27 -0400 Subject: vim-patch:8.1.1296: crash when using invalid command line argument Problem: Crash when using invalid command line argument. Solution: Check for options not being initialized. https://github.com/vim/vim/commit/27821260c0afaac85cb1c10627f1d7fbe48860ae --- src/nvim/testdir/test_startup.vim | 18 ++++++++---------- 1 file changed, 8 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/nvim/testdir/test_startup.vim b/src/nvim/testdir/test_startup.vim index 9abaca5957..b460798c5f 100644 --- a/src/nvim/testdir/test_startup.vim +++ b/src/nvim/testdir/test_startup.vim @@ -369,12 +369,11 @@ func Test_invalid_args() endfor if has('clientserver') - " FIXME: need to add --servername to this list - " but it causes vim-8.1.1282 to crash! for opt in ['--remote', '--remote-send', '--remote-silent', '--remote-expr', \ '--remote-tab', '--remote-tab-wait', \ '--remote-tab-wait-silent', '--remote-tab-silent', \ '--remote-wait', '--remote-wait-silent', + \ '--servername', \ ] let out = split(system(GetVimCommand() .. ' ' .. opt), "\n") call assert_equal(1, v:shell_error) @@ -384,14 +383,13 @@ func Test_invalid_args() endfor endif - " FIXME: commented out as this causes vim-8.1.1282 to crash! - "if has('clipboard') - " let out = split(system(GetVimCommand() .. ' --display'), "\n") - " call assert_equal(1, v:shell_error) - " call assert_match('^VIM - Vi IMproved .* (.*)$', out[0]) - " call assert_equal('Argument missing after: "--display"', out[1]) - " call assert_equal('More info with: "vim -h"', out[2]) - "endif + if has('clipboard') + let out = split(system(GetVimCommand() .. ' --display'), "\n") + call assert_equal(1, v:shell_error) + call assert_match('^VIM - Vi IMproved .* (.*)$', out[0]) + call assert_equal('Argument missing after: "--display"', out[1]) + call assert_equal('More info with: "vim -h"', out[2]) + endif let out = split(system(GetVimCommand() .. ' -ix'), "\n") call assert_equal(1, v:shell_error) -- cgit From 2ab6ec9e480741d37e31febf86f6272612f079f3 Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Wed, 9 Sep 2020 22:46:28 -0400 Subject: vim-patch:8.1.1297: invalid argument test fails without GTK Problem: Invalid argument test fails without GTK. Solution: Test -display and --display separately. https://github.com/vim/vim/commit/240f7abab01b5e3fd5336dd780e42501ec3f2fcb --- src/nvim/testdir/test_startup.vim | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) (limited to 'src') diff --git a/src/nvim/testdir/test_startup.vim b/src/nvim/testdir/test_startup.vim index b460798c5f..0b0cfb7a5c 100644 --- a/src/nvim/testdir/test_startup.vim +++ b/src/nvim/testdir/test_startup.vim @@ -383,7 +383,7 @@ func Test_invalid_args() endfor endif - if has('clipboard') + if has('gui_gtk') let out = split(system(GetVimCommand() .. ' --display'), "\n") call assert_equal(1, v:shell_error) call assert_match('^VIM - Vi IMproved .* (.*)$', out[0]) @@ -391,6 +391,14 @@ func Test_invalid_args() call assert_equal('More info with: "vim -h"', out[2]) endif + if has('clipboard') + let out = split(system(GetVimCommand() .. ' -display'), "\n") + call assert_equal(1, v:shell_error) + call assert_match('^VIM - Vi IMproved .* (.*)$', out[0]) + call assert_equal('Argument missing after: "-display"', out[1]) + call assert_equal('More info with: "vim -h"', out[2]) + endif + let out = split(system(GetVimCommand() .. ' -ix'), "\n") call assert_equal(1, v:shell_error) call assert_equal('nvim: Garbage after option argument: "-ix"', out[0]) -- cgit From 20b745b45b045a1a6e22f86f87483bdf1504e9c8 Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Wed, 9 Sep 2020 23:11:47 -0400 Subject: vim-patch:8.1.1298: invalid argument test fails without X clipboard MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Problem: Invalid argument test fails without X clipboard. Solution: Test -display only with the +xterm_clipboard feature. https://github.com/vim/vim/commit/5416b75031138182387399f8fe5e17a884414e1a N/A patches for version.c: vim-patch:8.2.1640: Amiga: missing header for getgrgid() Problem: Amiga: missing header for getgrgid(). Solution: Add the grp.h header. (Ola Söder, closes vim/vim#6906) https://github.com/vim/vim/commit/f842cd9e285afb9d86c6f9bff400e5e576f873c0 vim-patch:8.2.1645: GTK3: icons become broken images when resized Problem: GTK3: icons become broken images when resized. Solution: Use gtk_image_new_from_icon_name(). (closes vim/vim#6916) Fix compiler warnings. https://github.com/vim/vim/commit/81a4cf469a0f5c1603ac3130af9f011053854180 vim-patch:8.2.1646: Amiga: Unnecessary #include Problem: Amiga: Unnecessary #include. Solution: Remove the #include. (Ola Söder, closes vim/vim#6908) https://github.com/vim/vim/commit/33e3346322e40b2877f63f2f37398832c7017e2f vim-patch:8.2.1648: Amiga: no common build file for Amiga (-like) systems Problem: Amiga: no common build file for Amiga (-like) systems. Solution: Turn Make_morph.mak into Make_ami.mak. (Ola Söder, closes vim/vim#6805) https://github.com/vim/vim/commit/a62372be1f73b69f9d4c9413ec816d773a16a0f5 vim-patch:8.2.1649: GTK3: using old file chooser Problem: GTK3: using old file chooser. Solution: Use native file chooser on GTK 3.20 and above. (Yogeshwar Velingker, closes vim/vim#6909) https://github.com/vim/vim/commit/3e4cc9671c5551b73f0176cab40e676ed72a1716 vim-patch:8.2.1654: when job writes to hidden buffer current window is wrong Problem: When job writes to hidden buffer current window has display errors. (Johnny McArthur) Solution: Use aucmd_prepbuf() instead of switch_to_win_for_buf(). (closes vim/vim#6925) https://github.com/vim/vim/commit/ad9ec5e79916d206fd7677b77e36485c47ae534f vim-patch:8.2.1655: cannot build with Strawberry Perl 5.32.0 Problem: Cannot build with Strawberry Perl 5.32.0. Solution: Use Perl_sv_2pvbyte_flags. (closes vim/vim#6921) https://github.com/vim/vim/commit/895a7a472d2eb4413e63cdad3213cb1ef1633458 vim-patch:8.2.1661: cannot connect to 127.0.0.1 for host with only IPv6 addresses Problem: Cannot connect to 127.0.0.1 for host with only IPv6 addresses. Solution: pass AI_V4MAPPED flag to getaddrinfo. (Filipe Brandenburger, closes vim/vim#6931) https://github.com/vim/vim/commit/c6a67c92bcbf4ef09063814af0c65d3e0585ada0 --- src/nvim/testdir/test_startup.vim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src') diff --git a/src/nvim/testdir/test_startup.vim b/src/nvim/testdir/test_startup.vim index 0b0cfb7a5c..12bec745a8 100644 --- a/src/nvim/testdir/test_startup.vim +++ b/src/nvim/testdir/test_startup.vim @@ -391,7 +391,7 @@ func Test_invalid_args() call assert_equal('More info with: "vim -h"', out[2]) endif - if has('clipboard') + if has('xterm_clipboard') let out = split(system(GetVimCommand() .. ' -display'), "\n") call assert_equal(1, v:shell_error) call assert_match('^VIM - Vi IMproved .* (.*)$', out[0]) -- cgit