From fdbba2ccf7d3dfe9c9ad7306df2bf305014ce6cd Mon Sep 17 00:00:00 2001 From: shadmansaleh Date: Mon, 29 Mar 2021 09:48:07 +0600 Subject: Api: Adding cterm color support to nvim_set_hl --- src/nvim/api/vim.c | 6 ++++++ src/nvim/highlight.c | 34 ++++++++++++++++++++++++++++++++-- 2 files changed, 38 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/nvim/api/vim.c b/src/nvim/api/vim.c index 9dde62f0ee..c58240c1a3 100644 --- a/src/nvim/api/vim.c +++ b/src/nvim/api/vim.c @@ -217,6 +217,12 @@ Dictionary nvim__get_hl_defs(Integer ns_id, Error *err) /// in addition the following keys are also recognized: /// `default`: don't override existing definition, /// like `hi default` +/// `ctermfg`: sets foreground of cterm color +/// `ctermbg`: sets background of cterm color +/// `cterm` : cterm attribute map. sets attributed for +/// cterm colors. similer to `hi cterm` +/// Note: by default cterm attributes are +/// same as attributes of gui color /// @param[out] err Error details, if any /// /// TODO: ns_id = 0, should modify :highlight namespace diff --git a/src/nvim/highlight.c b/src/nvim/highlight.c index f03382bea7..228395a0d7 100644 --- a/src/nvim/highlight.c +++ b/src/nvim/highlight.c @@ -797,8 +797,11 @@ HlAttrs dict2hlattrs(Dictionary dict, bool use_rgb, int *link_id, Error *err) { HlAttrs hlattrs = HLATTRS_INIT; - int32_t fg = -1, bg = -1, sp = -1; + int32_t fg = -1, bg = -1, ctermfg = -1, ctermbg = -1, sp = -1; int16_t mask = 0; + int16_t cterm_mask = 0; + bool cterm_mask_provided = false; + for (size_t i = 0; i < dict.size; i++) { char *key = dict.items[i].key.data; Object val = dict.items[i].value; @@ -828,6 +831,24 @@ HlAttrs dict2hlattrs(Dictionary dict, bool use_rgb, int *link_id, Error *err) } } + // Handle cterm attrs + if (strequal(key, "cterm") && val.type == kObjectTypeDictionary){ + cterm_mask_provided = true; + Dictionary cterm_dict = val.data.dictionary; + for (size_t l = 0; l < cterm_dict.size; l++){ + char *cterm_dict_key = cterm_dict.items[l].key.data; + Object cterm_dict_val = cterm_dict.items[l].value; + for (int m = 0; flags[m].name; m++){ + if (strequal(flags[m].name, cterm_dict_key)){ + if (api_object_to_bool(cterm_dict_val, cterm_dict_key, false, err)){ + cterm_mask |= flags[m].flag; + } + break; + } + } + } + } + struct { const char *name; const char *shortname; @@ -835,6 +856,8 @@ HlAttrs dict2hlattrs(Dictionary dict, bool use_rgb, int *link_id, Error *err) } colors[] = { { "foreground", "fg", &fg }, { "background", "bg", &bg }, + { "ctermfg", NULL, &ctermfg }, + { "ctermbg", NULL, &ctermbg }, { "special", "sp", &sp }, { NULL, NULL, NULL }, }; @@ -879,13 +902,20 @@ HlAttrs dict2hlattrs(Dictionary dict, bool use_rgb, int *link_id, Error *err) } } + // apply gui mask as default for cterm mask + if (!cterm_mask_provided){ + cterm_mask = mask; + } if (use_rgb) { hlattrs.rgb_ae_attr = mask; hlattrs.rgb_bg_color = bg; hlattrs.rgb_fg_color = fg; hlattrs.rgb_sp_color = sp; + hlattrs.cterm_bg_color = ctermbg == -1 ? cterm_normal_bg_color : ctermbg + 1; + hlattrs.cterm_fg_color = ctermfg == -1 ? cterm_normal_fg_color : ctermfg + 1; + hlattrs.cterm_ae_attr = cterm_mask; } else { - hlattrs.cterm_ae_attr = mask; + hlattrs.cterm_ae_attr = cterm_mask; hlattrs.cterm_bg_color = bg == -1 ? cterm_normal_bg_color : bg + 1; hlattrs.cterm_fg_color = fg == -1 ? cterm_normal_fg_color : fg + 1; } -- cgit From fd62d398353ef775fc8bc794cb88ee3090310400 Mon Sep 17 00:00:00 2001 From: shadmansaleh Date: Mon, 29 Mar 2021 13:52:28 +0600 Subject: Make clint happy about spaces. --- src/nvim/api/vim.c | 2 +- src/nvim/highlight.c | 20 +++++++++++--------- 2 files changed, 12 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/nvim/api/vim.c b/src/nvim/api/vim.c index c58240c1a3..d93be55ee8 100644 --- a/src/nvim/api/vim.c +++ b/src/nvim/api/vim.c @@ -221,7 +221,7 @@ Dictionary nvim__get_hl_defs(Integer ns_id, Error *err) /// `ctermbg`: sets background of cterm color /// `cterm` : cterm attribute map. sets attributed for /// cterm colors. similer to `hi cterm` -/// Note: by default cterm attributes are +/// Note: by default cterm attributes are /// same as attributes of gui color /// @param[out] err Error details, if any /// diff --git a/src/nvim/highlight.c b/src/nvim/highlight.c index 228395a0d7..4a2bbc2739 100644 --- a/src/nvim/highlight.c +++ b/src/nvim/highlight.c @@ -832,15 +832,16 @@ HlAttrs dict2hlattrs(Dictionary dict, bool use_rgb, int *link_id, Error *err) } // Handle cterm attrs - if (strequal(key, "cterm") && val.type == kObjectTypeDictionary){ + if (strequal(key, "cterm") && val.type == kObjectTypeDictionary) { cterm_mask_provided = true; Dictionary cterm_dict = val.data.dictionary; - for (size_t l = 0; l < cterm_dict.size; l++){ + for (size_t l = 0; l < cterm_dict.size; l++) { char *cterm_dict_key = cterm_dict.items[l].key.data; Object cterm_dict_val = cterm_dict.items[l].value; - for (int m = 0; flags[m].name; m++){ - if (strequal(flags[m].name, cterm_dict_key)){ - if (api_object_to_bool(cterm_dict_val, cterm_dict_key, false, err)){ + for (int m = 0; flags[m].name; m++) { + if (strequal(flags[m].name, cterm_dict_key)) { + if (api_object_to_bool(cterm_dict_val, cterm_dict_key, false, + err)) { cterm_mask |= flags[m].flag; } break; @@ -881,7 +882,6 @@ HlAttrs dict2hlattrs(Dictionary dict, bool use_rgb, int *link_id, Error *err) } } - if (flags[j].name || colors[k].name) { // handled above } else if (link_id && strequal(key, "link")) { @@ -903,7 +903,7 @@ HlAttrs dict2hlattrs(Dictionary dict, bool use_rgb, int *link_id, Error *err) } // apply gui mask as default for cterm mask - if (!cterm_mask_provided){ + if (!cterm_mask_provided) { cterm_mask = mask; } if (use_rgb) { @@ -911,8 +911,10 @@ HlAttrs dict2hlattrs(Dictionary dict, bool use_rgb, int *link_id, Error *err) hlattrs.rgb_bg_color = bg; hlattrs.rgb_fg_color = fg; hlattrs.rgb_sp_color = sp; - hlattrs.cterm_bg_color = ctermbg == -1 ? cterm_normal_bg_color : ctermbg + 1; - hlattrs.cterm_fg_color = ctermfg == -1 ? cterm_normal_fg_color : ctermfg + 1; + hlattrs.cterm_bg_color = + ctermbg == -1 ? cterm_normal_bg_color : ctermbg + 1; + hlattrs.cterm_fg_color = + ctermfg == -1 ? cterm_normal_fg_color : ctermfg + 1; hlattrs.cterm_ae_attr = cterm_mask; } else { hlattrs.cterm_ae_attr = cterm_mask; -- cgit