From a095a48987469865577d1035109877354bb67f5c Mon Sep 17 00:00:00 2001 From: Jan Edmund Lazo Date: Sun, 15 Jul 2018 22:12:47 -0400 Subject: clint: detect MAYBE and recommend TriState Vim uses MAYBE for 3-value boolean with FALSE/TRUE/MAYBE. Use TriState type instead to restrict to 3 values, kFalse/kTrue/kNone. --- src/clint.py | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'src') diff --git a/src/clint.py b/src/clint.py index c0cedc0e5b..9fd93ce143 100755 --- a/src/clint.py +++ b/src/clint.py @@ -3299,6 +3299,13 @@ def CheckLanguage(filename, clean_lines, linenum, file_extension, error(filename, linenum, 'readability/bool', 4, 'Use %s instead of %s.' % (token.lower(), token)) + # Detect MAYBE + match = Search(r'\b(MAYBE)\b', line) + if match: + token = match.group(1) + error(filename, linenum, 'readability/bool', 4, + 'Use kNONE from TriState instead of %s.' % token) + # Detect preincrement/predecrement match = Match(r'^\s*(?:\+\+|--)', line) if match: -- cgit