From 1feaa450cb024a4cd4eb3ae7ab7e5db683909488 Mon Sep 17 00:00:00 2001 From: James McCoy Date: Sun, 1 Jan 2017 22:34:17 -0500 Subject: vim-patch:7.4.1866 Problem: Invalid memory access when exiting with EXITFREE defined. (Dominique Pelle) Solution: Set "really_exiting" and skip error messages. https://github.com/vim/vim/commit/a96732150cda2f242133228579b05437a39b8daa This fails to build, due to a00c2e0ecbaec366364cecb5efbdb456c8c543ef removing really_exiting from globals.h, but the next commit fixes the build failure. --- src/nvim/eval.c | 5 ++++- src/nvim/memory.c | 3 +++ src/nvim/version.c | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/nvim/eval.c b/src/nvim/eval.c index 32e1991742..c900cf5dfb 100644 --- a/src/nvim/eval.c +++ b/src/nvim/eval.c @@ -21569,7 +21569,10 @@ void func_unref(char_u *name) if (name != NULL && isdigit(*name)) { fp = find_func(name); if (fp == NULL) { - EMSG2(_(e_intern2), "func_unref()"); + // Ignore when invoked through free_all_mem(). + if (!really_exiting) { + EMSG2(_(e_intern2), "func_unref()"); + } } else { user_func_unref(fp); } diff --git a/src/nvim/memory.c b/src/nvim/memory.c index 071ef335cf..63914f3a46 100644 --- a/src/nvim/memory.c +++ b/src/nvim/memory.c @@ -496,6 +496,9 @@ void free_all_mem(void) return; entered = true; + // Set this flag to indicate some errors can be ignored. + really_exiting = true; + // Don't want to trigger autocommands from here on. block_autocmds(); diff --git a/src/nvim/version.c b/src/nvim/version.c index 9f2b7a26c3..7244a53606 100644 --- a/src/nvim/version.c +++ b/src/nvim/version.c @@ -574,7 +574,7 @@ static int included_patches[] = { // 1869 NA // 1868, 1867, - // 1866, + 1866, // 1865 NA // 1864 NA // 1863 NA -- cgit From 945540b7825e2909d17d8b8867330c3ace7c759c Mon Sep 17 00:00:00 2001 From: James McCoy Date: Sun, 1 Jan 2017 22:47:55 -0500 Subject: vim-patch:7.4.1868 Problem: Setting really_exiting causes memory leaks to be reported. Solution: Add the in_free_all_mem flag. https://github.com/vim/vim/commit/b89a25f17e274dc308c584ea69a129ffbb26bc3d --- src/nvim/eval.c | 6 +++--- src/nvim/globals.h | 4 ++++ src/nvim/memory.c | 8 ++------ src/nvim/version.c | 2 +- 4 files changed, 10 insertions(+), 10 deletions(-) (limited to 'src') diff --git a/src/nvim/eval.c b/src/nvim/eval.c index c900cf5dfb..f769016936 100644 --- a/src/nvim/eval.c +++ b/src/nvim/eval.c @@ -21569,10 +21569,10 @@ void func_unref(char_u *name) if (name != NULL && isdigit(*name)) { fp = find_func(name); if (fp == NULL) { - // Ignore when invoked through free_all_mem(). - if (!really_exiting) { +#ifdef EXITFREE + if (!entered_free_all_mem) +#endif EMSG2(_(e_intern2), "func_unref()"); - } } else { user_func_unref(fp); } diff --git a/src/nvim/globals.h b/src/nvim/globals.h index fbffc2d44d..bc98971c0b 100644 --- a/src/nvim/globals.h +++ b/src/nvim/globals.h @@ -636,6 +636,10 @@ EXTERN int exiting INIT(= FALSE); /* TRUE when planning to exit Vim. Might * still keep on running if there is a changed * buffer. */ +#if defined(EXITFREE) +// true when in or after free_all_mem() +EXTERN bool entered_free_all_mem INIT(= false); +#endif /* volatile because it is used in signal handler deathtrap(). */ EXTERN volatile int full_screen INIT(= FALSE); /* TRUE when doing full-screen output diff --git a/src/nvim/memory.c b/src/nvim/memory.c index 63914f3a46..ca6aa6381d 100644 --- a/src/nvim/memory.c +++ b/src/nvim/memory.c @@ -488,16 +488,12 @@ void time_to_bytes(time_t time_, uint8_t buf[8]) void free_all_mem(void) { buf_T *buf, *nextbuf; - static bool entered = false; /* When we cause a crash here it is caught and Vim tries to exit cleanly. * Don't try freeing everything again. */ - if (entered) + if (entered_free_all_mem) return; - entered = true; - - // Set this flag to indicate some errors can be ignored. - really_exiting = true; + entered_free_all_mem = true; // Don't want to trigger autocommands from here on. block_autocmds(); diff --git a/src/nvim/version.c b/src/nvim/version.c index 7244a53606..61ffb1cae6 100644 --- a/src/nvim/version.c +++ b/src/nvim/version.c @@ -572,7 +572,7 @@ static int included_patches[] = { 1871, // 1870 NA // 1869 NA - // 1868, + 1868, 1867, 1866, // 1865 NA -- cgit