From ad60b3fb4806c0917010bbe97876c22fb57cabcd Mon Sep 17 00:00:00 2001 From: "Cai Rijun (Richard)" <1297550+cairijun@users.noreply.github.com> Date: Tue, 11 Feb 2025 01:37:36 +0800 Subject: fix(api): memory leaks in vim.api.nvim_*get_option #32390 Problem: `get_option_value` returns caller owned `Object`s but the corresponding C apis do not marked `FUNC_API_RET_ALLOC` properly. Solution: add `FUNC_API_RET_ALLOC` to the C apis. --- test/functional/api/deprecated_spec.lua | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'test/functional/api/deprecated_spec.lua') diff --git a/test/functional/api/deprecated_spec.lua b/test/functional/api/deprecated_spec.lua index 2efcfda873..d967bfa743 100644 --- a/test/functional/api/deprecated_spec.lua +++ b/test/functional/api/deprecated_spec.lua @@ -18,4 +18,15 @@ describe('deprecated', function() n.api.nvim_notify('hello world', 4, {}) end) end) + + describe('nvim_*get_option functions', function() + it('does not leak memory', function() + -- String opts caused memory leaks in these functions in Github#32361 + n.exec_lua([[ + vim.api.nvim_get_option('rtp') + vim.api.nvim_win_get_option(vim.api.nvim_get_current_win(), 'foldmethod') + vim.api.nvim_buf_get_option(0, 'fileformat') + ]]) + end) + end) end) -- cgit