From 2afbce7651f79b0626ebeae3688274ce18ac2920 Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Sun, 19 Sep 2021 02:29:37 -0700 Subject: refactor(tests): remove redir_exec #15718 Problem - `redir_exec` is obsolete, but it keeps getting used in new tests because people copy existing tests. - Disadvantages of `redir_exec`: - Captures extra junk before the actual error/message that we _want_ to test. - Does not fail on error, unlike e.g. `command()`. Solution - Use new functions like `nvim_exec` and `pcall_err`. --- test/functional/vimscript/json_functions_spec.lua | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'test/functional/vimscript/json_functions_spec.lua') diff --git a/test/functional/vimscript/json_functions_spec.lua b/test/functional/vimscript/json_functions_spec.lua index 9b5e207c07..c3b607b544 100644 --- a/test/functional/vimscript/json_functions_spec.lua +++ b/test/functional/vimscript/json_functions_spec.lua @@ -6,7 +6,7 @@ local eq = helpers.eq local eval = helpers.eval local command = helpers.command local exc_exec = helpers.exc_exec -local redir_exec = helpers.redir_exec +local pcall_err = helpers.pcall_err local NIL = helpers.NIL local source = helpers.source @@ -517,9 +517,8 @@ describe('json_decode() function', function() it('does not overflow when writing error message about decoding ["", ""]', function() - eq('\nE474: Attempt to decode a blank string' - .. '\nE474: Failed to parse \n', - redir_exec('call json_decode(["", ""])')) + eq('Vim(call):E474: Attempt to decode a blank string', + pcall_err(command, 'call json_decode(["", ""])')) end) end) -- cgit