From 2afbce7651f79b0626ebeae3688274ce18ac2920 Mon Sep 17 00:00:00 2001 From: "Justin M. Keyes" Date: Sun, 19 Sep 2021 02:29:37 -0700 Subject: refactor(tests): remove redir_exec #15718 Problem - `redir_exec` is obsolete, but it keeps getting used in new tests because people copy existing tests. - Disadvantages of `redir_exec`: - Captures extra junk before the actual error/message that we _want_ to test. - Does not fail on error, unlike e.g. `command()`. Solution - Use new functions like `nvim_exec` and `pcall_err`. --- test/functional/vimscript/let_spec.lua | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'test/functional/vimscript/let_spec.lua') diff --git a/test/functional/vimscript/let_spec.lua b/test/functional/vimscript/let_spec.lua index 5bc703b567..4ff4090a18 100644 --- a/test/functional/vimscript/let_spec.lua +++ b/test/functional/vimscript/let_spec.lua @@ -5,7 +5,7 @@ local clear = helpers.clear local command = helpers.command local eval = helpers.eval local meths = helpers.meths -local redir_exec = helpers.redir_exec +local exec_capture = helpers.exec_capture local source = helpers.source local nvim_dir = helpers.nvim_dir @@ -14,14 +14,14 @@ before_each(clear) describe(':let', function() it('correctly lists variables with curly-braces', function() meths.set_var('v', {0}) - eq('\nv [0]', redir_exec('let {"v"}')) + eq('v [0]', exec_capture('let {"v"}')) end) it('correctly lists variables with subscript', function() meths.set_var('v', {0}) - eq('\nv[0] #0', redir_exec('let v[0]')) - eq('\ng:["v"][0] #0', redir_exec('let g:["v"][0]')) - eq('\n{"g:"}["v"][0] #0', redir_exec('let {"g:"}["v"][0]')) + eq('v[0] #0', exec_capture('let v[0]')) + eq('g:["v"][0] #0', exec_capture('let g:["v"][0]')) + eq('{"g:"}["v"][0] #0', exec_capture('let {"g:"}["v"][0]')) end) it(":unlet self-referencing node in a List graph #6070", function() -- cgit