From 353a4be7e84fdc101318215bdcc8a7e780d737fe Mon Sep 17 00:00:00 2001 From: dundargoc Date: Sun, 12 Nov 2023 13:13:58 +0100 Subject: build: remove PVS We already have an extensive suite of static analysis tools we use, which causes a fair bit of redundancy as we get duplicate warnings. PVS is also prone to give false warnings which creates a lot of work to identify and disable. --- test/functional/fixtures/printargs-test.c | 3 --- test/functional/fixtures/printenv-test.c | 3 --- test/functional/fixtures/shell-test.c | 3 --- test/functional/fixtures/streams-test.c | 3 --- test/functional/fixtures/tty-test.c | 11 +++-------- 5 files changed, 3 insertions(+), 20 deletions(-) (limited to 'test/functional') diff --git a/test/functional/fixtures/printargs-test.c b/test/functional/fixtures/printargs-test.c index be54605817..2c25cf8447 100644 --- a/test/functional/fixtures/printargs-test.c +++ b/test/functional/fixtures/printargs-test.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include int main(int argc, char **argv) diff --git a/test/functional/fixtures/printenv-test.c b/test/functional/fixtures/printenv-test.c index 295b4f04c3..f826a28db4 100644 --- a/test/functional/fixtures/printenv-test.c +++ b/test/functional/fixtures/printenv-test.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #ifdef MSWIN diff --git a/test/functional/fixtures/shell-test.c b/test/functional/fixtures/shell-test.c index 4196716799..ef9f23e3f9 100644 --- a/test/functional/fixtures/shell-test.c +++ b/test/functional/fixtures/shell-test.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include #include diff --git a/test/functional/fixtures/streams-test.c b/test/functional/fixtures/streams-test.c index be40edfe7e..5a59abb33b 100644 --- a/test/functional/fixtures/streams-test.c +++ b/test/functional/fixtures/streams-test.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - /// Helper program to exit and keep stdout open (like "xclip -i -loops 1"). #include diff --git a/test/functional/fixtures/tty-test.c b/test/functional/fixtures/tty-test.c index 6ee7715021..f94af2fd12 100644 --- a/test/functional/fixtures/tty-test.c +++ b/test/functional/fixtures/tty-test.c @@ -1,6 +1,3 @@ -// This is an open source non-commercial project. Dear PVS-Studio, please check -// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com - #include #include #include @@ -11,8 +8,6 @@ # include #endif -// -V:STRUCT_CAST:641 -#define STRUCT_CAST(Type, obj) ((Type *)(obj)) #define is_terminal(stream) (uv_guess_handle(fileno(stream)) == UV_TTY) #define BUF_SIZE 0xfff #define CTRL_C 0x03 @@ -108,10 +103,10 @@ static void read_cb(uv_stream_t *stream, ssize_t cnt, const uv_buf_t *buf) .len = (size_t)cnt #endif }; - uv_write(&req, STRUCT_CAST(uv_stream_t, &out), &b, 1, NULL); + uv_write(&req, (uv_stream_t *)&out, &b, 1, NULL); uv_run(&write_loop, UV_RUN_DEFAULT); - uv_close(STRUCT_CAST(uv_handle_t, &out), NULL); + uv_close((uv_handle_t *)&out, NULL); uv_run(&write_loop, UV_RUN_DEFAULT); if (uv_loop_close(&write_loop)) { abort(); @@ -181,7 +176,7 @@ int main(int argc, char **argv) #endif uv_tty_set_mode(&tty, UV_TTY_MODE_RAW); tty.data = &interrupted; - uv_read_start(STRUCT_CAST(uv_stream_t, &tty), alloc_cb, read_cb); + uv_read_start((uv_stream_t *)&tty, alloc_cb, read_cb); #ifndef MSWIN struct sigaction sa; sigemptyset(&sa.sa_mask); -- cgit