From 01edcd6db85ab2abffa95bc4dce6cfb8de617bca Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Sat, 2 Dec 2023 10:07:13 +0800 Subject: vim-patch:9.0.2141: [security]: buffer-overflow in suggest_trie_walk Problem: [security]: buffer-overflow in suggest_trie_walk Solution: Check n before using it as index into byts array Basically, n as an index into the byts array, can point to beyond the byts array. So let's double check, that n is within the expected range after incrementing it from sp->ts_curi and bail out if it would be invalid. Reported by @henices, thanks! https://github.com/vim/vim/commit/0fb375aae608d7306b4baf9c1f906961f32e2abf Co-authored-by: Christian Brabandt --- test/old/testdir/crash/poc_suggest_trie_walk | Bin 0 -> 100 bytes test/old/testdir/test_crash.vim | 8 ++++++++ 2 files changed, 8 insertions(+) create mode 100644 test/old/testdir/crash/poc_suggest_trie_walk (limited to 'test') diff --git a/test/old/testdir/crash/poc_suggest_trie_walk b/test/old/testdir/crash/poc_suggest_trie_walk new file mode 100644 index 0000000000..c79b6eeb5c Binary files /dev/null and b/test/old/testdir/crash/poc_suggest_trie_walk differ diff --git a/test/old/testdir/test_crash.vim b/test/old/testdir/test_crash.vim index 11c5f4e014..eef1731454 100644 --- a/test/old/testdir/test_crash.vim +++ b/test/old/testdir/test_crash.vim @@ -135,6 +135,13 @@ func Test_crash1_2() \ ' && echo "crash 2: [OK]" >> '.. result .. "\") call TermWait(buf, 350) + let file = 'crash/poc_suggest_trie_walk' + let cmn_args = "%s -u NONE -i NONE -n -e -s -S %s -c ':qa!'" + let args = printf(cmn_args, vim, file) + call term_sendkeys(buf, args .. + \ ' && echo "crash 3: [OK]" >> '.. result .. "\") + call TermWait(buf, 150) + " clean up exe buf .. "bw!" @@ -143,6 +150,7 @@ func Test_crash1_2() let expected = [ \ 'crash 1: [OK]', \ 'crash 2: [OK]', + \ 'crash 3: [OK]', \ ] call assert_equal(expected, getline(1, '$')) -- cgit