From a9eeeec5d5a64a8f3a11f38319d70537f929e667 Mon Sep 17 00:00:00 2001 From: Dylan Armstrong Date: Fri, 26 Feb 2021 19:55:32 -0600 Subject: test: segfault test for empty buffer paste on term --- test/functional/terminal/buffer_spec.lua | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'test') diff --git a/test/functional/terminal/buffer_spec.lua b/test/functional/terminal/buffer_spec.lua index 209537831f..5d1e2618c1 100644 --- a/test/functional/terminal/buffer_spec.lua +++ b/test/functional/terminal/buffer_spec.lua @@ -258,6 +258,13 @@ describe(':terminal buffer', function() it('handles wqall', function() eq('Vim(wqall):E948: Job still running', exc_exec('wqall')) end) + + it('does not segfault when pasting empty buffer #13955', function() + feed_command('terminal') + feed('') + feed_command('put a') -- buffer a is empty + eq(2, eval('1+1')) -- check nvim still running + end) end) describe('No heap-buffer-overflow when using', function() -- cgit From 1d4a7c60391de69af21502b09e4f00ecb01b4bf9 Mon Sep 17 00:00:00 2001 From: Dylan Armstrong Date: Sat, 27 Feb 2021 09:38:38 -0600 Subject: test: use assert_alive helper rather than eq --- test/functional/terminal/buffer_spec.lua | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'test') diff --git a/test/functional/terminal/buffer_spec.lua b/test/functional/terminal/buffer_spec.lua index 5d1e2618c1..297678a531 100644 --- a/test/functional/terminal/buffer_spec.lua +++ b/test/functional/terminal/buffer_spec.lua @@ -263,7 +263,7 @@ describe(':terminal buffer', function() feed_command('terminal') feed('') feed_command('put a') -- buffer a is empty - eq(2, eval('1+1')) -- check nvim still running + helpers.assert_alive() end) end) @@ -284,7 +284,7 @@ describe('No heap-buffer-overflow when using', function() feed('$') -- Let termopen() modify the buffer feed_command('call termopen("echo")') - eq(2, eval('1+1')) -- check nvim still running + helpers.assert_alive() feed_command('bdelete!') end) end) @@ -294,6 +294,6 @@ describe('No heap-buffer-overflow when', function() feed_command('set nowrap') feed_command('autocmd TermOpen * startinsert') feed_command('call feedkeys("4000ai\\:terminal!\\")') - eq(2, eval('1+1')) + helpers.assert_alive() end) end) -- cgit From 6646280d1a7a110cdc41edbc944ccdd05326fa6c Mon Sep 17 00:00:00 2001 From: Dylan Armstrong Date: Sat, 27 Feb 2021 10:02:56 -0600 Subject: chore: revert unrelated changes in test --- test/functional/terminal/buffer_spec.lua | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'test') diff --git a/test/functional/terminal/buffer_spec.lua b/test/functional/terminal/buffer_spec.lua index 297678a531..c61bf108cb 100644 --- a/test/functional/terminal/buffer_spec.lua +++ b/test/functional/terminal/buffer_spec.lua @@ -284,7 +284,7 @@ describe('No heap-buffer-overflow when using', function() feed('$') -- Let termopen() modify the buffer feed_command('call termopen("echo")') - helpers.assert_alive() + eq(2, eval('1+1')) -- check nvim still running feed_command('bdelete!') end) end) @@ -294,6 +294,6 @@ describe('No heap-buffer-overflow when', function() feed_command('set nowrap') feed_command('autocmd TermOpen * startinsert') feed_command('call feedkeys("4000ai\\:terminal!\\")') - helpers.assert_alive() + eq(2, eval('1+1')) end) end) -- cgit