From 79d2351ce8acbd579081e558cdbaebe333e10153 Mon Sep 17 00:00:00 2001 From: nicm Date: Mon, 27 Aug 2018 11:03:34 +0000 Subject: Memory leaks, from Gang Fan in GitHub issue 1453. --- cmd-run-shell.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'cmd-run-shell.c') diff --git a/cmd-run-shell.c b/cmd-run-shell.c index ff12b5cd..47fceafe 100644 --- a/cmd-run-shell.c +++ b/cmd-run-shell.c @@ -102,8 +102,12 @@ cmd_run_shell_exec(struct cmd *self, struct cmdq_item *item) if (!args_has(args, 'b')) cdata->item = item; - job_run(cdata->cmd, s, server_client_get_cwd(item->client, s), NULL, - cmd_run_shell_callback, cmd_run_shell_free, cdata, 0); + if (job_run(cdata->cmd, s, server_client_get_cwd(item->client, s), NULL, + cmd_run_shell_callback, cmd_run_shell_free, cdata, 0) == NULL) { + cmdq_error(item, "failed to run command: %s", cdata->cmd); + free(cdata); + return (CMD_RETURN_ERROR); + } if (args_has(args, 'b')) return (CMD_RETURN_NORMAL); -- cgit