From 03d173cbd8e72c356512a0e19e356b07d518627a Mon Sep 17 00:00:00 2001
From: nicm <nicm>
Date: Wed, 25 Aug 2021 08:51:55 +0000
Subject: Validate command argument types (string or command list) and give
 more useful error messages.

---
 cmd.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

(limited to 'cmd.c')

diff --git a/cmd.c b/cmd.c
index 930ee56c..62c8b9ab 100644
--- a/cmd.c
+++ b/cmd.c
@@ -502,6 +502,7 @@ cmd_parse(struct args_value *values, u_int count, const char *file, u_int line,
 	const struct cmd_entry	*entry;
 	struct cmd		*cmd;
 	struct args		*args;
+	char			*error;
 
 	if (count == 0 || values[0].type != ARGS_STRING) {
 		xasprintf(cause, "no command");
@@ -511,11 +512,16 @@ cmd_parse(struct args_value *values, u_int count, const char *file, u_int line,
 	if (entry == NULL)
 		return (NULL);
 
-	args = args_parse(&entry->args, values, count);
-	if (args == NULL) {
+	args = args_parse(&entry->args, values, count, &error);
+	if (args == NULL && error == NULL) {
 		xasprintf(cause, "usage: %s %s", entry->name, entry->usage);
 		return (NULL);
 	}
+	if (args == NULL) {
+		xasprintf(cause, "command %s: %s", entry->name, error);
+		free(error);
+		return (NULL);
+	}
 
 	cmd = xcalloc(1, sizeof *cmd);
 	cmd->entry = entry;
-- 
cgit