From 28687f2d55fb30654a7164bf1445f47b052ea115 Mon Sep 17 00:00:00 2001 From: nicm Date: Mon, 3 Jul 2017 08:16:03 +0000 Subject: Do not close panes until process has exited and any outstanding data has been written to the pipe-pane event if there is one. GitHub issue 991. --- window.c | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) (limited to 'window.c') diff --git a/window.c b/window.c index ce5166c8..55739c0e 100644 --- a/window.c +++ b/window.c @@ -388,6 +388,19 @@ window_destroy(struct window *w) free(w); } +int +window_pane_destroy_ready(struct window_pane *wp) +{ + if (wp->pipe_fd != -1 && EVBUFFER_LENGTH(wp->pipe_event->output) != 0) + return (0); + + if (~wp->flags & PANE_EXITED) + return (0); + if (~wp->flags & PANE_ERROR) + return (0); + return (1); +} + void window_add_ref(struct window *w, const char *from) { @@ -1000,7 +1013,11 @@ window_pane_error_callback(__unused struct bufferevent *bufev, { struct window_pane *wp = data; - server_destroy_pane(wp, 1); + log_debug("%%%u error", wp->id); + wp->flags |= PANE_ERROR; + + if (window_pane_destroy_ready(wp)) + server_destroy_pane(wp, 1); } void -- cgit