diff options
| author | Rob Pilling <robpilling@gmail.com> | 2026-07-26 22:40:06 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2026-07-26 17:40:06 -0400 |
| commit | c57818bb43903aeb2cbdf2f3604d0c333d4e5641 (patch) | |
| tree | dd2d9db6ebc7dc5e11f1a71b4a6dfb0f3d600c25 /runtime/autoload/python.vim | |
| parent | fdc09be03cb10a1e11a31abd2ddd96d3f131b486 (diff) | |
| download | rneovim-c57818bb43903aeb2cbdf2f3604d0c333d4e5641.tar.gz rneovim-c57818bb43903aeb2cbdf2f3604d0c333d4e5641.tar.bz2 rneovim-c57818bb43903aeb2cbdf2f3604d0c333d4e5641.zip | |
fix(ui2): avoid flickering fileinfo messages #41002
## Flicker cause
ui2's `check_targets()` function creates the hidden ui2 windows with this call chain:
```
nvim_open_win()
win_set_buf()
do_buffer()
set_curbuf()
enter_buffer()
```
and `enter_buffer()` sets `need_fileinfo`:
https://github.com/neovim/neovim/blob/fdc09be03cb10a1e11a31abd2ddd96d3f131b486/src/nvim/buffer.c#L1837-L1839
This is then picked up by `normal_redraw`:
https://github.com/neovim/neovim/blob/fdc09be03cb10a1e11a31abd2ddd96d3f131b486/src/nvim/normal.c#L1381-L1385
The fileinfo message then causes a ui2 window to appear to display it:
https://github.com/neovim/neovim/blob/fdc09be03cb10a1e11a31abd2ddd96d3f131b486/runtime/lua/vim/_core/ui2/messages.lua#L325-L330
... which ends up calling `set_pos`, which registers an `on_key` handler:
https://github.com/neovim/neovim/blob/fdc09be03cb10a1e11a31abd2ddd96d3f131b486/runtime/lua/vim/_core/ui2/messages.lua#L726-L728
This handler closes the ui2 window when the user presses, for example, `l` (because the user's not focusing said window).
The handler eventually calls `check_targets()`:
https://github.com/neovim/neovim/blob/fdc09be03cb10a1e11a31abd2ddd96d3f131b486/runtime/lua/vim/_core/ui2/messages.lua#L594-L595
and `check_targets()` takes us back to the beginning, causing the ui2 window flicker
## Repro
```vim
=require("vim._core.ui2").enable()
set ch=0 shm-=F ve=all
e /tmp/x
```
Then hit `Ctrl-G` to show fileinfo (if not already shown) and hold `l`
## Fix
Effectively surround the ui2 window creating with `:silent`
Diffstat (limited to 'runtime/autoload/python.vim')
0 files changed, 0 insertions, 0 deletions