diff options
| author | Evgeni Chasnovski <evgeni.chasnovski@gmail.com> | 2025-11-29 19:36:05 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2025-11-29 12:36:05 -0500 |
| commit | 28ff4deda7a0c452d3a35de3da5e5ff676824915 (patch) | |
| tree | eb48309cbe0fa260be410e489d638c336aeeaf02 /test/functional/vimscript/executable_spec.lua | |
| parent | a950e8ea9d38ab2e75f7341aea44c865b211584e (diff) | |
| download | rneovim-28ff4deda7a0c452d3a35de3da5e5ff676824915.tar.gz rneovim-28ff4deda7a0c452d3a35de3da5e5ff676824915.tar.bz2 rneovim-28ff4deda7a0c452d3a35de3da5e5ff676824915.zip | |
fix(colorscheme): adjust `StatusLine[NC]` for diagnostics #36719
Problem: It is desirable for the default statusline to contain colored
diagnostics information. However, current `StatusLine` group is
purposefully defined as almost inverted `Normal` to "make current
window obvious". This makes diagnostic information from
`vim.diagnostic.status()` barely visible: it uses established
`DiagnosticSignXxx` groups which have colored foreground with
lightness close to `StatusLine` background.
Also the `StatusLineNC` group is fairly different from `Normal` in
order to both "makes window separators clear" and "be different from
`CursorLine`". But not as mush different as `StatusLine` because
"`StatusLine` and `StatusLineNC` should be clearly different".
Solution: Make both `StatusLine` and `StatusLineNC` be slightly closer
in lightness to `Normal`. This makes `StatusLine` and `StatusLineNC`
groups satisfy their conditions in the following way:
- `vim.diagnostic.count()` is readable on `StatusLine` - yes.
- `vim.diagnostic.count()` is readable on `StatusLineNC` - yes.
- `StatusLine` makes current window obvious - I'd say yes.
- `StatusLine` and `StatusLineNC` are clearly different - it depends
on the eyes and monitor. The current is clearly better, but the new
ones I'd say are still visibly different.
- `StatusLineNC` makes window separators clear - I'd say yes, but
depends on the eyes and monitor.
- `StatuslineNC` is different from `CursorLine` - NO, they are same.
Another approach to solve this would be to introduce dedicated
`DiagnosticStatuslineXxx` groups to use in `vim.diagnostics.status()`.
They can be defined using foreground colors from the same lightness as
`Normal`. This would make them readable in `StatusLine`. But not
`StatusLineNC`, though.
Diffstat (limited to 'test/functional/vimscript/executable_spec.lua')
0 files changed, 0 insertions, 0 deletions