aboutsummaryrefslogtreecommitdiff
path: root/src
</
Commit message (Collapse)AuthorAge
...
| * | | | | | fix(stream): do not close handle if it is already closing (#26537)Gregory Anders2023-12-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | uv_close asserts that a handle is not already closing. We can guard against this assertion failure by manually checking the handle's closing status ourselves.
| * | | | | | fix(lua): memory leak when using invalid syntax with exists() (#26530)zeertzjq2023-12-12
| | | | | | |
| * | | | | | feat(eval): exists() function supports checking v:lua functions (#26485)Raphael2023-12-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Vimscript function exists() can't check v:lua functions. Solution: Add support for v:lua functions to exists().
| * | | | | | Merge pull request #26486 from glepnir/fix_linebytebfredl2023-12-12
| |\ \ \ \ \ \ | | | | | | | | | | | | | | | | fix(eval): use no_ff instead of ffdos as condition
| | * | | | | | fix: use no_ff instead of ffdos as conditionglepnir2023-12-12
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: line2byte behavior is changed after commit b051b13. It no longer return `-1` on empty buffer. Solution: use `nof_ff` instead of `!ff_dos` as condition. Then compatible behavior of line2byte() is restored.
| * | | | | | | fix(extmarks): `U` changed_bytes after extmark_splice (#26501)Jaehwang Jung2023-12-12
| | | | | | | | | | | | | | | | | | | | | | | | See also: https://github.com/neovim/neovim/pull/26364
| * | | | | | | fix(tui): don't forget to update cursor visibility (#26523)zeertzjq2023-12-12
| | | | | | | |
| * | | | | | | fix(coverity): unhandled retval for marktree_itr_get_overlap() #26518luukvbaal2023-12-11
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | buf_signcols_validate_range() is only called in a buffer with signs, in which the marktree is thus non-empty. Also remove a redundant comment, condition and variable. *** CID 470331: Error handling issues (CHECKED_RETURN) /src/nvim/decoration.c: 824 in buf_signcols_validate_range() 818 819 // Allocate an array of integers holding the overlapping signs in the range. 820 assert(row2 >= row1); 821 int *overlap = xcalloc(sizeof(int), (size_t)(row2 + 1 - row1)); 822 823 // First find the number of overlapping signs at "row1". >>> CID 470331: Error handling issues (CHECKED_RETURN) >>> Calling "marktree_itr_get_overlap" without checking return value (as is done elsewhere 4 out of 5 times). 824 marktree_itr_get_overlap(buf->b_marktree, currow, 0, itr); 825 while (marktree_itr_step_overlap(buf->b_marktree, itr, &pair)) { 826 if (!mt_invalid(pair.start) && pair.start.flags & MT_FLAG_DECOR_SIGNTEXT) { 827 overlap[0]++; 828 } 829 }
| * | | | | | | Merge pull request #26458 from famiu/refactor/options/optionindexdundargoc2023-12-10
| |\ \ \ \ \ \ \
| | * | | | | | | refactor(options): define `kOptIndexCount`Famiu Haque2023-12-10
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Add a macro to indicate the option count so that we can iterate through the options[] table more clearly. This also removes the need for having an option with NULL fullname at the end of `options[]`.
| | * | | | | | | refactor(options): convert `opt_idx` variables to `OptIndex`Famiu Haque2023-12-09
| | | | | | | | |
| | * | | | | | | refactor(options): reduce `findoption()` usageFamiu Haque2023-12-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Many places in the code use `findoption()` to access an option using its name, even if the option index is available. This is very slow because it requires looping through the options array over and over. Solution: Use option index instead of name wherever possible. Also introduce an `OptIndex` enum which contains the index for every option as enum constants, this eliminates the need to pass static option names as strings.
| * | | | | | | | build: remove config-specific find_package search for libuvdundargoc2023-12-09
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | Having two separate find_package calls makes it harder to maintain.
| * | | | | | | refactor: format casting of negative number better (#26482)zeertzjq2023-12-09
| | | | | | | |
| * | | | | | | refactor(tui): use synchronized updates around actual buf flush (#26478)Gregory Anders2023-12-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Rather than writing the synchronized update begin and end sequences into the TUI's internal buffer (where it is later flushed to the TTY), write these sequences directly to the TTY before and after the TUI's internal buffer is itself flushed to the TTY. This guarantees that a synchronized update is always used when we are actually sending data to the TTY. This means we do not need to keep track of the TUI's "dirty" state (any sequences which affect the TUI state will be written in the TUI's internal buffer, which is now guaranteed to only ever be written when a synchronized update is active).
| * | | | | | | vim-patch:9.0.2154: The option[] array is not sorted (#26475)zeertzjq2023-12-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: The options[] array is not sorted alphabetically. Solution: Sort it alphabetically. Add a test. Avoid unnecessary loop iterations in findoption(). closes: vim/vim#13648 Cherry-pick Test_set_one_column() change from patch 8.2.0432. https://github.com/vim/vim/commit/f48558e10a08a1a483e25ef847bbceeac6b44561
| * | | | | | | perf(column): avoid counting when max signs are removed from a rangeLuuk van Baal2023-12-08
| | | | | | | |
| * | | | | | | fix(tui): start flush earlier (#26463)zeertzjq2023-12-08
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: TUI flush (start sync or hide cursor) only starts on a "flush" event, which is too late. Solution: Start the next flush when anything will be drawn.
| * | | | | | | Merge pull request #26456 from gpanders/ignore-vim-runtimeGregory Anders2023-12-07
| |\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | fix(terminal): ignore $VIM and $VIMRUNTIME in pty jobs
| | * | | | | | | fix(terminal): ignore $VIM and $VIMRUNTIME in pty jobsGregory Anders2023-12-07
| | | | | | | | |
| * | | | | | | | refactor(options): split `get_option_value()` into smaller functionsFamiu Haque2023-12-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Currently, `get_option_value()` returns 3 separate things: The actual value of the option, whether the option is hidden, and the option flags. This makes the function difficult to refactor, modify or otherwise reason about. Solution: Split `get_option_value()` into 3 functions, each with a single purpose. This also affects `get_option_value_for()`.
| * | | | | | | | fix(lua): allow nil values in serialized Lua arrays (#26329)Gregory Anders2023-12-07
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we convert a Lua table to an Object, we consider the table a "dictionary" if it contains only string keys, and an array if it contains all numeric indices with no gaps. While rare, Lua tables can have both strictly numeric indices and gaps (e.g. { [2] = 2 }). These currently cannot be serialized because it is not considered an array. However, we know the maximum index of the table and as long as all of the keys in the table are numeric, it is still possible to serialize this table as an array. The missing indices will have nil values.
| * | | | | | | perf(column): keep track of number of lines that hold up the 'signcolumn'Luuk van Baal2023-12-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: The entire marktree needs to be traversed each time a sign is removed from the sentinel line. Solution: Remove sentinel line and instead keep track of the number of lines that hold up the 'signcolumn' in "max_count". Adjust this number for added/removed signs, and set it to 0 when the maximum number of signs on a line changes. Only when "max_count" is decremented to 0 due to sign removal do we need to check the entire buffer. Also replace "invalid_top" and "invalid_bot" with a map of invalid ranges, further reducing the number of lines to be checked. Also improve tree traversal when counting the number of signs. Instead of looping over the to be checked range and counting the overlap for each row, keep track of the overlap in an array and add this to the count.
| * | | | | | | refactor: object_to_vim() cannot failJustin M. Keyes2023-12-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since the parent commit, object_to_vim() can't fail, so callers don't need to check its result.
| * | | | | | | feat(rpc): allow empty string key in msgpack => Vim conversionJustin M. Keyes2023-12-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Problem: Since e057b38e7037 #20757 we support empty key in JSON encode/decode, but we don't allow it in RPC object => Vim dict conversion. But empty string is a valid key in Vim dicts and the msgpack spec. Empty string key was disallowed in 7c01d5ff9286 (2014) but that commit/PR doesn't explicitly discuss it, so presumably it was a "seems reasonable" decision (or Vimscript didn't allow empty keys until later). Solution: Remove the check in `object_to_vim()`. Note that `tv_dict_item_alloc_len` will invoke `memcpy(…, 0)` but that's allowed by the C spec: https://stackoverflow.com/a/3751937/152142
| * | | | | | | Merge pull request #26438 from jamessan/log_spec-nameJames McCoy2023-12-07