From d7af8707026968887ea4ee3a4e6fa51fd4372033 Mon Sep 17 00:00:00 2001
From: Lewis Russell <lewis6991@gmail.com>
Date: Thu, 24 Sep 2026 13:30:07 +0100
Subject: fix(lua): enable nil-safety diagnostics in runtime code

Enable EmmyLua's need-check-nil diagnostic and resolve nullable values
through more precise types, explicit invariants, and guards for missing
runtime state. Keep analyzer-specific workarounds local and update the
affected API documentation.

Exclude the bundled re.lua from analysis so its nil-check warnings do
not fail CI.

AI-assisted
---
 runtime/lua/vim/loader.lua | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

(limited to 'runtime/lua/vim/loader.lua')

diff --git a/runtime/lua/vim/loader.lua b/runtime/lua/vim/loader.lua
index 9d2df52dbb..9c6d66d0e9 100644
--- a/runtime/lua/vim/loader.lua
+++ b/runtime/lua/vim/loader.lua
@@ -46,7 +46,9 @@ local M = {}
 --- The fs_stat of the module path. Won't be returned for `modname="*"`
 --- @field stat? uv.fs_stat.result
 
---- @alias vim.loader.Stats table<string, {total:number, time:number, [string]:number?}?>
+--- @class (private) vim.loader.Stats
+--- @field [string] {total:number, time:number, [string]:number?}?>
+--- @field find {total:number, time:number, not_found:number, stat?:number}
 
 --- @private
 M.path = vim.fn.stdpath('cache') .. '/luac'
@@ -255,7 +257,8 @@ end
 --- @param filename? string
 --- @param mode? "b"|"t"|"bt"
 --- @param env? table
---- @return function?, string?  error_message
+--- @return_overload function chunk
+--- @return_overload nil, string error_message
 local function loadfile_cached(filename, mode, env)
   local modpath = normalize(filename)
   local stat = fs_stat_cached(modpath)
@@ -286,7 +289,7 @@ local function lsmod(path)
     for name, t in fs.dir(path .. '/lua') do
       local modpath = path .. '/lua/' .. name
       -- HACK: type is not always returned due to a bug in luv
-      t = t or fs_stat_cached(modpath).type
+      t = t or assert(fs_stat_cached(modpath)).type
       --- @type string
       local topname
       local ext = name:sub(-4)
@@ -499,7 +502,7 @@ function M._profile(opts)
 
   if opts and opts.loaders then
     for l, loader in pairs(loaders) do
-      local loc = debug.getinfo(loader, 'Sn').source:gsub('^@', '')
+      local loc = assert(debug.getinfo(loader, 'Sn')).source:gsub('^@', '')
       loaders[l] = track('loader ' .. l .. ': ' .. loc, loader)
     end
   end
-- 
cgit