From fa3920282da007f0ea7ce37873ccb3c1db0af0ec Mon Sep 17 00:00:00 2001 From: Evgeni Chasnovski Date: Mon, 8 Sep 2025 00:42:09 +0300 Subject: fix(pack): handle Git environment variables #35626 Problem: Some environment variables which are useful when working inside a bare repository can affect any Git operation. Solution: Explicitly unset problematic environment variables. --- test/functional/plugin/pack_spec.lua | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) (limited to 'test/functional/plugin/pack_spec.lua') diff --git a/test/functional/plugin/pack_spec.lua b/test/functional/plugin/pack_spec.lua index a8664b80b9..bbd9ada85a 100644 --- a/test/functional/plugin/pack_spec.lua +++ b/test/functional/plugin/pack_spec.lua @@ -664,6 +664,19 @@ describe('vim.pack', function() eq('basic main', exec_lua('return require("basic")')) end) + it('is not affected by special environment variables', function() + fn.setenv('GIT_WORK_TREE', fn.getcwd()) + fn.setenv('GIT_DIR', vim.fs.joinpath(fn.getcwd(), '.git')) + local ref_environ = fn.environ() + + exec_lua(function() + vim.pack.add({ repos_src.basic }) + end) + eq('basic main', exec_lua('return require("basic")')) + + eq(ref_environ, fn.environ()) + end) + it('validates input', function() local validate = function(err_pat, input) local add_input = function() @@ -1163,6 +1176,20 @@ describe('vim.pack', function() eq({ 'return "fetch new 2"' }, fn.readfile(fetch_lua_file)) end) + it('is not affected by special environment variables', function() + fn.setenv('GIT_WORK_TREE', fn.getcwd()) + fn.setenv('GIT_DIR', vim.fs.joinpath(fn.getcwd(), '.git')) + local ref_environ = fn.environ() + + exec_lua(function() + vim.pack.add({ repos_src.fetch }) + vim.pack.update({ 'fetch' }, { force = true }) + end) + eq({ 'return "fetch new 2"' }, fn.readfile(fetch_lua_file)) + + eq(ref_environ, fn.environ()) + end) + it('validates input', function() local validate = function(err_pat, input) local update_input = function() -- cgit