From 9c5ade9212d897db590aeb6a2a5340e73ffe44d0 Mon Sep 17 00:00:00 2001 From: zeertzjq Date: Fri, 13 Feb 2026 21:02:40 +0800 Subject: fix: wait() checks condition twice on each interval (#37837) Problem: wait() checks condition twice on each interval. Solution: Don't schedule the due callback. Also fix memory leak when Nvim exits while waiting. No test that the condition isn't checked twice, as testing for that can be flaky when there are libuv events from other sources. --- test/functional/vimscript/wait_spec.lua | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'test/functional/vimscript/wait_spec.lua') diff --git a/test/functional/vimscript/wait_spec.lua b/test/functional/vimscript/wait_spec.lua index 0932bd3593..3ac7399c52 100644 --- a/test/functional/vimscript/wait_spec.lua +++ b/test/functional/vimscript/wait_spec.lua @@ -78,4 +78,15 @@ describe('wait()', function() eq('Vim:E475: Invalid value for argument 3', pcall_err(call, 'wait', 0, 1, 0)) eq('Vim:E475: Invalid value for argument 3', pcall_err(call, 'wait', 0, 1, '')) end) + + it('does not leak when Nvim exits while waiting', function() + n.expect_exit( + 500, + source, + [[ + call timer_start(10, {-> execute('qall!')}) + call wait(10000, 0) + ]] + ) + end) end) -- cgit