diff options
| author | dundargoc <33953936+dundargoc@users.noreply.github.com> | 2023-02-18 17:43:39 +0100 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-02-18 17:43:39 +0100 |
| commit | 9301abdf748b54fa3d41375cc4659ca9f4b57dd8 (patch) | |
| tree | 56fea10bbd401ca8369d0a0dc82ed19dd56e18d0 /.github/workflows | |
| parent | 6ed5a9ab8c1908e49565acabe94121e79139a050 (diff) | |
| download | rneovim-9301abdf748b54fa3d41375cc4659ca9f4b57dd8.tar.gz rneovim-9301abdf748b54fa3d41375cc4659ca9f4b57dd8.tar.bz2 rneovim-9301abdf748b54fa3d41375cc4659ca9f4b57dd8.zip | |
ci: enable CI_BUILD automatically if environment variable CI is true (#22312)
Having to specify CI_BUILD for every CI job requires boilerplate. More
importantly, it's easy to forget to enable CI_BUILD, as seen by
8a20f9f98a90a7a43aea08fcde2c40a5356b4f7b. It's simpler to remember to
turn CI_BUILD off when a job errors instead of remembering that every
new job should have CI_BUILD on.
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/build.yml | 2 | ||||
| -rw-r--r-- | .github/workflows/release.yml | 4 | ||||
| -rw-r--r-- | .github/workflows/test.yml | 12 |
3 files changed, 10 insertions, 8 deletions
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 6b9c63b2d8..23ced47c6d 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -67,7 +67,7 @@ jobs: run: make deps - name: Build - run: make CMAKE_FLAGS="-D CI_BUILD=ON -D CMAKE_INSTALL_PREFIX:PATH=$INSTALL_PREFIX" + run: make CMAKE_FLAGS="-D CMAKE_INSTALL_PREFIX:PATH=$INSTALL_PREFIX" - name: Install run: make install diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index ee2845dd17..4447beab2e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -33,7 +33,7 @@ jobs: - name: Build release id: build run: | - CC=gcc-10 make CMAKE_BUILD_TYPE=${NVIM_BUILD_TYPE} CMAKE_EXTRA_FLAGS="-DCMAKE_INSTALL_PREFIX:PATH=" + CC=gcc-10 make CMAKE_BUILD_TYPE=${NVIM_BUILD_TYPE} CMAKE_EXTRA_FLAGS="-DCI_BUILD=OFF -DCMAKE_INSTALL_PREFIX:PATH=" printf 'version<<END\n' >> $GITHUB_OUTPUT ./build/bin/nvim --version | head -n 3 >> $GITHUB_OUTPUT printf 'END\n' >> $GITHUB_OUTPUT @@ -127,7 +127,7 @@ jobs: cmake --build .deps - name: build package run: | - cmake -B build -G Ninja -DCMAKE_BUILD_TYPE='RelWithDebInfo' + cmake -B build -G Ninja -DCMAKE_BUILD_TYPE='RelWithDebInfo' -D CI_BUILD=OFF cmake --build build --target package - uses: actions/upload-artifact@v3 with: diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d9fdeaec9b..3bd982477a 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -89,10 +89,12 @@ jobs: args: --check runtime/ - if: success() || failure() && steps.abort_job.outputs.status == 'success' + name: configure + run: cmake -B build -G Ninja -D CI_BUILD=OFF + + - if: success() || failure() && steps.abort_job.outputs.status == 'success' name: luacheck - run: | - cmake -B build -G Ninja - cmake --build build --target lintlua-luacheck + run: cmake --build build --target lintlua-luacheck - if: success() || failure() && steps.abort_job.outputs.status == 'success' name: lintsh @@ -198,7 +200,7 @@ jobs: - name: Build run: | - cmake -B build -G Ninja -D CI_BUILD=ON -D CMAKE_INSTALL_PREFIX:PATH=$INSTALL_PREFIX ${{ matrix.flags }} + cmake -B build -G Ninja -D CMAKE_INSTALL_PREFIX:PATH=$INSTALL_PREFIX ${{ matrix.flags }} cmake --build build - if: "!cancelled()" @@ -318,7 +320,7 @@ jobs: - name: Build run: | - cmake -B build -G Ninja -D CMAKE_BUILD_TYPE='RelWithDebInfo' -D CI_BUILD=ON + cmake -B build -G Ninja -D CMAKE_BUILD_TYPE='RelWithDebInfo' cmake --build build - name: Install test deps |