diff options
| author | Henry Fraser <henrymfraser@gmail.com> | 2022-04-12 00:58:46 +1000 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-11 07:58:46 -0700 |
| commit | 96b461a00042c13610a62545b17fb792eb17c12e (patch) | |
| tree | a3907dc20d784f083aa608924bb85163017f2724 /.github/workflows | |
| parent | 356cff78ece597059133e33eceb955f72286a319 (diff) | |
| download | rneovim-96b461a00042c13610a62545b17fb792eb17c12e.tar.gz rneovim-96b461a00042c13610a62545b17fb792eb17c12e.tar.bz2 rneovim-96b461a00042c13610a62545b17fb792eb17c12e.zip | |
refactor(packaging): Windows: improve MSI, remove NSIS #18069
- Removed NSIS installer.
- Prevents undefined behaviour when two installations are performed to the same directory (NSIS + MSI).
- Reduced cost of maintaining two installers that do the same thing.
- Chose Wix MSI due to its better integration with Windows.
- Added Wix patch file to add neovim binaries to the system path during installation.
- Replaced neovim installer icons with better looking versions.
- Renamed neovim installer icons from logo.ico -> neovim.ico for all
icons to better reflect contents.
Diffstat (limited to '.github/workflows')
| -rw-r--r-- | .github/workflows/notes.md | 10 | ||||
| -rw-r--r-- | .github/workflows/release.yml | 7 |
2 files changed, 0 insertions, 17 deletions
diff --git a/.github/workflows/notes.md b/.github/workflows/notes.md index 7181972696..3bd6c739a5 100644 --- a/.github/workflows/notes.md +++ b/.github/workflows/notes.md @@ -16,15 +16,6 @@ ${NVIM_VERSION} 1. Download **nvim-win64.msi** 2. Run the MSI -3. Add the Neovim location to your path. - - Default location is `C:\Program Files\Neovim` -4. Search and run `nvim-qt.exe` or run `nvim.exe` on your CLI of choice. - -#### NSIS - -1. Download **nvim-win64.exe** -2. Run the installer. - - Ensure that the option to add the installation location to your path is checked if it's your first installation. 3. Search and run `nvim-qt.exe` or run `nvim.exe` on your CLI of choice. ### macOS @@ -70,5 +61,4 @@ ${SHA_APP_IMAGE_ZSYNC} ${SHA_MACOS} ${SHA_WIN_64_ZIP} ${SHA_WIN_64_MSI} -${SHA_WIN_64_EXE} ``` diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 8e0b13d59c..be93cd0245 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -146,11 +146,6 @@ jobs: name: ${{ matrix.archive }} path: build/${{ matrix.archive }}.msi retention-days: 1 - - uses: actions/upload-artifact@v2 - with: - name: ${{ matrix.archive }} - path: build/${{ matrix.archive }}.exe - retention-days: 1 publish: needs: [linux, appimage, macOS, windows] @@ -226,8 +221,6 @@ jobs: echo "SHA_WIN_64_ZIP=$(cat nvim-win64.zip.sha256sum)" >> $GITHUB_ENV sha256sum nvim-win64.msi > nvim-win64.msi.sha256sum echo "SHA_WIN_64_MSI=$(cat nvim-win64.msi.sha256sum)" >> $GITHUB_ENV - sha256sum nvim-win64.exe > nvim-win64.exe.sha256sum - echo "SHA_WIN_64_EXE=$(cat nvim-win64.exe.sha256sum)" >> $GITHUB_ENV - name: Publish release env: GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} |