aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRui Abreu Ferreira <raf-ep@gmx.com>2014-11-14 14:35:16 +0000
committerRui Abreu Ferreira <raf-ep@gmx.com>2014-11-14 14:35:16 +0000
commit2b887ec66ba28f6d6fcbfdd121522fd7093bcc65 (patch)
treeeed711ff88f6ca00449c2eba620e2181b0e90638
parent8da78bc3ae694aa2a6edaac97756211374491471 (diff)
downloadrneovim-2b887ec66ba28f6d6fcbfdd121522fd7093bcc65.tar.gz
rneovim-2b887ec66ba28f6d6fcbfdd121522fd7093bcc65.tar.bz2
rneovim-2b887ec66ba28f6d6fcbfdd121522fd7093bcc65.zip
Use cmake --build instead of Make
- If possble try to abstract away from Make, and use cmake --build - third-party still needs to find Make to build some components - Removed search for Make from CMakeLists.txt * for CMake < 3.0 --build has no color output
-rw-r--r--CMakeLists.txt31
-rw-r--r--third-party/CMakeLists.txt3
-rw-r--r--third-party/cmake/InstallMsgpack.cmake2
3 files changed, 2 insertions, 34 deletions
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 9482e6d8a4..f7ecf10816 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -205,28 +205,6 @@ if(NOT BUSTED_OUTPUT_TYPE)
set(BUSTED_OUTPUT_TYPE "utfTerminal")
endif()
-# Setup make.
-find_program(MAKE_PRG NAMES gmake make)
-if(MAKE_PRG)
- execute_process(
- COMMAND "${MAKE_PRG}" --version
- OUTPUT_VARIABLE MAKE_VERSION_INFO)
- if(NOT "${OUTPUT_VARIABLE}" MATCHES ".*GNU.*")
- unset(MAKE_PRG)
- endif()
-endif()
-if(NOT MAKE_PRG)
- message(FATAL_ERROR "GNU Make is required to build the dependencies.")
-else()
- message(STATUS "Found GNU Make at ${MAKE_PRG}")
-endif()
-
-# When using make, use the $(MAKE) variable to avoid warnings about the job
-# server.
-if(CMAKE_GENERATOR MATCHES "Makefiles")
- set(MAKE_PRG "$(MAKE)")
-endif()
-
# CMake is painful here. It will create the destination using the user's
# current umask, and we don't want that. And we don't just want to install
# the target directory, as it will mess with existing permissions. So this
@@ -251,15 +229,6 @@ endforeach()
install(SCRIPT ${PROJECT_SOURCE_DIR}/cmake/GenerateHelptags.cmake)
-# Unfortunately, the below does not work under Ninja. Ninja doesn't use a
-# pseudo-tty when launching processes, because it can put many jobs in parallel
-# and eat-up all the available pseudo-ttys. Unfortunately, that doesn't work
-# well with the legacy tests. I have a branch that converts them to run under
-# CTest, but it needs a little more work.
-# add_custom_target(test
-# COMMAND ${MAKE_PRG} -C ${CMAKE_CURRENT_SOURCE_DIR}/src/nvim/testdir
-# VIMPROG=${CMAKE_RUNTIME_OUTPUT_DIRECTORY}/nvim)
-
# Go down the tree.
add_subdirectory(src/nvim)
diff --git a/third-party/CMakeLists.txt b/third-party/CMakeLists.txt
index 166d48785a..38c5533ddd 100644
--- a/third-party/CMakeLists.txt
+++ b/third-party/CMakeLists.txt
@@ -106,9 +106,8 @@ if(USE_BUNDLED_MSGPACK)
-DCMAKE_INSTALL_PREFIX=${DEPS_INSTALL_DIR}
-DCMAKE_C_COMPILER=${CMAKE_C_COMPILER}
"-DCMAKE_C_FLAGS:STRING=${CMAKE_C_COMPILER_ARG1} -fPIC"
- BUILD_COMMAND ${MAKE_PRG}
+ BUILD_COMMAND ${CMAKE_COMMAND} --build .
INSTALL_COMMAND ${CMAKE_COMMAND}
- -DMAKE_PRG=${MAKE_PRG}
-DREMOVE_FILE_GLOB=${DEPS_INSTALL_DIR}/lib/${CMAKE_SHARED_LIBRARY_PREFIX}msgpack*${CMAKE_SHARED_LIBRARY_SUFFIX}*
-P ${CMAKE_CURRENT_SOURCE_DIR}/cmake/InstallMsgpack.cmake)
list(APPEND THIRD_PARTY_DEPS msgpack)
diff --git a/third-party/cmake/InstallMsgpack.cmake b/third-party/cmake/InstallMsgpack.cmake
index d5e5d7e816..eda77f3b84 100644
--- a/third-party/cmake/InstallMsgpack.cmake
+++ b/third-party/cmake/InstallMsgpack.cmake
@@ -1,5 +1,5 @@
execute_process(
- COMMAND ${MAKE_PRG} install
+ COMMAND ${CMAKE_COMMAND} --build . --target install
RESULT_VARIABLE res)
if(NOT res EQUAL 0)