diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2022-08-05 07:54:14 +0800 |
|---|---|---|
| committer | zeertzjq <zeertzjq@outlook.com> | 2022-08-05 07:56:56 +0800 |
| commit | 57fbcc6929e8c2a9da1b17c75c062dc64dcd0a62 (patch) | |
| tree | 93974bf51be576954edcd90f8404d45182df79d0 | |
| parent | d985323c555b894e0a6eb8bb283bb0318467c476 (diff) | |
| download | rneovim-57fbcc6929e8c2a9da1b17c75c062dc64dcd0a62.tar.gz rneovim-57fbcc6929e8c2a9da1b17c75c062dc64dcd0a62.tar.bz2 rneovim-57fbcc6929e8c2a9da1b17c75c062dc64dcd0a62.zip | |
vim-patch:8.2.0478: new buffers are not added to the Buffers menu
Problem: New buffers are not added to the Buffers menu.
Solution: Turn number into string. (Yee Cheng Chin, closes vim/vim#5864)
https://github.com/vim/vim/commit/5908fdf72fa1995735e38c46f254ddde81a87c1f
| -rw-r--r-- | runtime/menu.vim | 4 | ||||
| -rw-r--r-- | src/nvim/testdir/test_menu.vim | 14 |
2 files changed, 14 insertions, 4 deletions
diff --git a/runtime/menu.vim b/runtime/menu.vim index 706e3072d7..0a5ac36095 100644 --- a/runtime/menu.vim +++ b/runtime/menu.vim @@ -2,7 +2,7 @@ " You can also use this as a start for your own set of menus. " " Maintainer: Bram Moolenaar <Bram@vim.org> -" Last Change: 2020 Mar 19 +" Last Change: 2020 Mar 29 " Note that ":an" (short for ":anoremenu") is often used to make a menu work " in all modes and avoid side effects from mappings defined by the user. @@ -672,7 +672,7 @@ func s:BMAdd() call s:BMShow() else let name = expand("<afile>") - let num = expand("<abuf>") + let num = expand("<abuf>") + 0 " add zero to convert to a number type if s:BMCanAdd(name, num) call <SID>BMFilename(name, num) let s:bmenu_count += 1 diff --git a/src/nvim/testdir/test_menu.vim b/src/nvim/testdir/test_menu.vim index d3287d4ea9..c85da7f5b1 100644 --- a/src/nvim/testdir/test_menu.vim +++ b/src/nvim/testdir/test_menu.vim @@ -33,10 +33,17 @@ func Test_buffer_menu_special_buffers() let orig_buffer_menus = execute("nmenu Buffers") + " Test that regular new buffer results in a new buffer menu item. + new + let new_buffer_menus = execute('nmenu Buffers') + call assert_equal(len(split(orig_buffer_menus, "\n")) + 2, len(split(new_buffer_menus, "\n"))) + bwipe! + call assert_equal(orig_buffer_menus, execute("nmenu Buffers")) + " Make a new command-line window, test that it does not create a new buffer " menu. call feedkeys("q::let cmdline_buffer_menus=execute('nmenu Buffers')\<CR>:q\<CR>", 'ntx') - call assert_equal(len(split(orig_buffer_menus, "\n")), len(split(cmdline_buffer_menus, "\n"))) + call assert_equal(len(split(orig_buffer_menus, "\n")) + 2, len(split(cmdline_buffer_menus, "\n"))) call assert_equal(orig_buffer_menus, execute("nmenu Buffers")) if has('terminal') @@ -44,7 +51,7 @@ func Test_buffer_menu_special_buffers() " item. terminal let term_buffer_menus = execute('nmenu Buffers') - call assert_equal(len(split(orig_buffer_menus, "\n")), len(split(term_buffer_menus, "\n"))) + call assert_equal(len(split(orig_buffer_menus, "\n")) + 2, len(split(term_buffer_menus, "\n"))) bwipe! call assert_equal(orig_buffer_menus, execute("nmenu Buffers")) endif @@ -155,6 +162,9 @@ endfunc " Test for menu item completion in command line func Test_menu_expand() + " Make sure we don't have stale menu items like Buffers menu. + source $VIMRUNTIME/delmenu.vim + " Create the menu itmes for test menu Dummy.Nothing lll for i in range(1, 4) |