diff options
| author | zeertzjq <zeertzjq@outlook.com> | 2023-05-23 18:11:03 +0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2023-05-23 18:11:03 +0800 |
| commit | 677e02be4e1255435a39d25a4b12ecbed4fff37b (patch) | |
| tree | 9411b30ef70fc0682d07c1bc17f3aa697b07b0ac | |
| parent | 30c02781cac103312e022d62797c08fef0f3e6c1 (diff) | |
| download | rneovim-677e02be4e1255435a39d25a4b12ecbed4fff37b.tar.gz rneovim-677e02be4e1255435a39d25a4b12ecbed4fff37b.tar.bz2 rneovim-677e02be4e1255435a39d25a4b12ecbed4fff37b.zip | |
refactor: fix clang/PVS warnings (#23731)
| -rw-r--r-- | src/nvim/ex_docmd.c | 1 | ||||
| -rw-r--r-- | src/nvim/fileio.c | 3 | ||||
| -rw-r--r-- | src/nvim/generators/gen_ex_cmds.lua | 1 | ||||
| -rw-r--r-- | src/nvim/lua/executor.c | 2 | ||||
| -rw-r--r-- | src/nvim/lua/secure.c | 3 |
5 files changed, 6 insertions, 4 deletions
diff --git a/src/nvim/ex_docmd.c b/src/nvim/ex_docmd.c index fcac833e6f..9666d80de2 100644 --- a/src/nvim/ex_docmd.c +++ b/src/nvim/ex_docmd.c @@ -48,7 +48,6 @@ #include "nvim/highlight_group.h" #include "nvim/input.h" #include "nvim/keycodes.h" -#include "nvim/lua/secure.h" #include "nvim/macros.h" #include "nvim/main.h" #include "nvim/mark.h" diff --git a/src/nvim/fileio.c b/src/nvim/fileio.c index 57aa063504..e60007bf88 100644 --- a/src/nvim/fileio.c +++ b/src/nvim/fileio.c @@ -3481,8 +3481,7 @@ void vim_deltempdir(void) char *vim_gettempdir(void) { static int notfound = 0; - bool exists = false; - if (vim_tempdir == NULL || !(exists = os_isdir(vim_tempdir))) { + if (vim_tempdir == NULL || !os_isdir(vim_tempdir)) { if (vim_tempdir != NULL) { notfound++; if (notfound == 1) { diff --git a/src/nvim/generators/gen_ex_cmds.lua b/src/nvim/generators/gen_ex_cmds.lua index 76b372eac2..b9fae7d0fe 100644 --- a/src/nvim/generators/gen_ex_cmds.lua +++ b/src/nvim/generators/gen_ex_cmds.lua @@ -55,6 +55,7 @@ defsfile:write(string.format([[ #include "nvim/help.h" #include "nvim/indent.h" #include "nvim/lua/executor.h" +#include "nvim/lua/secure.h" #include "nvim/mapping.h" #include "nvim/mark.h" #include "nvim/match.h" diff --git a/src/nvim/lua/executor.c b/src/nvim/lua/executor.c index 0069ba8ceb..8c1d8addcd 100644 --- a/src/nvim/lua/executor.c +++ b/src/nvim/lua/executor.c @@ -341,7 +341,7 @@ static int nlua_init_argv(lua_State *const L, char **argv, int argc, int lua_arg lua_pushstring(L, argv[lua_arg0 - 1]); lua_rawseti(L, -2, 0); // _G.arg[0] = "foo.lua" - for (; lua_arg0 >= 0 && i + lua_arg0 < argc; i++) { + for (; i + lua_arg0 < argc; i++) { lua_pushstring(L, argv[i + lua_arg0]); lua_rawseti(L, -2, i + 1); // _G.arg[i+1] = "--foo" } diff --git a/src/nvim/lua/secure.c b/src/nvim/lua/secure.c index 59fdd6d819..30d5a95fc0 100644 --- a/src/nvim/lua/secure.c +++ b/src/nvim/lua/secure.c @@ -1,3 +1,6 @@ +// This is an open source non-commercial project. Dear PVS-Studio, please check +// it. PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com + #include <lauxlib.h> #include <lua.h> #include <lualib.h> |