diff options
| author | L Lllvvuu <git@llllvvuu.dev> | 2023-09-11 23:15:24 -0700 |
|---|---|---|
| committer | Christian Clason <c.clason@uni-graz.at> | 2023-09-12 09:12:53 +0200 |
| commit | 6b5f44817e93c2985f3ea32122f1dc0047054018 (patch) | |
| tree | 235d42bdd5251ba4cddd11b46fa0262e9fa25c27 | |
| parent | 3849cc9c18f877751c2a72fb82887ab7f88e0ffa (diff) | |
| download | rneovim-6b5f44817e93c2985f3ea32122f1dc0047054018.tar.gz rneovim-6b5f44817e93c2985f3ea32122f1dc0047054018.tar.bz2 rneovim-6b5f44817e93c2985f3ea32122f1dc0047054018.zip | |
fix(languagetree): remove double recursion in LanguageTree:parse
`LanguageTree:parse` is recursive, and calls
`LanguageTree:for_each_child`, which is also recursive.
That means that, starting from the third level (child of child of root),
nodes will be parsed twice.
Which then means that if the tree is N layers deep, there will be ~2^N
parses even if the branching factor is 1.
Now, why was the tree deepening with each character inserted? And why
did this only regress in #24647? These are mysteries for another time.
Fixes: #25104
| -rw-r--r-- | runtime/lua/vim/treesitter/languagetree.lua | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/runtime/lua/vim/treesitter/languagetree.lua b/runtime/lua/vim/treesitter/languagetree.lua index e81778b269..3c60da7643 100644 --- a/runtime/lua/vim/treesitter/languagetree.lua +++ b/runtime/lua/vim/treesitter/languagetree.lua @@ -444,9 +444,9 @@ function LanguageTree:parse(range) range = range, }) - self:for_each_child(function(child) + for _, child in pairs(self._children) do child:parse(range) - end) + end return self._trees end |